From: changhuaixin <changhuaixin@linux.alibaba.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: changhuaixin <changhuaixin@linux.alibaba.com>,
bp@alien8.de, hpa@zytor.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, luto@amacapital.net,
michal.lkml@markovi.net, mingo@redhat.com,
Peter Zijlstra <peterz@infradead.org>,
tglx@linutronix.de, x86@kernel.org,
yamada.masahiro@socionext.com, jpoimboe@redhat.com
Subject: Re: [PATCH 1/3] scripts/sorttable: Change section type of orc_lookup to SHT_PROGBITS
Date: Fri, 7 Aug 2020 12:22:56 +0800 [thread overview]
Message-ID: <C605557D-951C-4FA7-9CE2-940B92FD198D@linux.alibaba.com> (raw)
In-Reply-To: <20200806150810.GA2127855@gmail.com>
> On Aug 6, 2020, at 11:08 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
>
> * changhuaixin <changhuaixin@linux.alibaba.com> wrote:
>
>> Hi, Ingo
>>
>> Another way to write SHT_PROGBITS is using elf_create_section to write orc_lookup table headers, when orc_unwind_ip table and orc_unwind table are written. Is this a better solution?
>>
>> diff --git a/tools/objtool/orc_gen.c b/tools/objtool/orc_gen.c
>> index 3f98dcfbc177..860d4dcec8e6 100644
>> --- a/tools/objtool/orc_gen.c
>> +++ b/tools/objtool/orc_gen.c
>> @@ -183,6 +183,10 @@ int create_orc_sections(struct objtool_file *file)
>> u_sec = elf_create_section(file->elf, ".orc_unwind",
>> sizeof(struct orc_entry), idx);
>>
>> + /* make flags of section orc_lookup right */
>> + if (!elf_create_section(file->elf, ".orc_lookup", sizeof(int), 0))
>> + return -1;
>> +
>> /* populate sections */
>> idx = 0;
>> for_each_sec(file, sec) {
>
> Looks much nicer IMO.
>
> Mind turning this into a proper patch that does it plus reverts the
> hack?
>
A new patchset is sent.
Thanks,
huaixin
> Thanks,
>
> Ingo
next prev parent reply other threads:[~2020-08-07 4:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 3:46 [PATCH RESEND 0/3] Build ORC fast lookup table in scripts/sorttable tool Huaixin Chang
2020-07-23 3:46 ` [PATCH 1/3] scripts/sorttable: Change section type of orc_lookup to SHT_PROGBITS Huaixin Chang
2020-07-24 13:55 ` Ingo Molnar
2020-08-04 1:40 ` changhuaixin
2020-08-06 15:08 ` Ingo Molnar
2020-08-07 4:22 ` changhuaixin [this message]
2020-07-23 3:46 ` [PATCH 2/3] scripts/sorttable: Build orc fast lookup table via sorttable tool Huaixin Chang
2020-07-24 13:53 ` Ingo Molnar
2020-07-27 2:19 ` changhuaixin
2020-07-23 3:46 ` [PATCH 3/3] x86/unwind/orc: Simplify unwind_init() for x86 boot Huaixin Chang
2020-08-07 4:17 ` [PATCH v2 0/3] Build ORC fast lookup table in scripts/sorttable tool Huaixin Chang
2020-08-07 4:18 ` [PATCH 1/3] objtool: Write .orc_lookup section header Huaixin Chang
2020-08-07 4:18 ` [PATCH 2/3] scripts/sorttable: Build ORC fast lookup table via sorttable tool Huaixin Chang
2020-08-07 4:18 ` [PATCH 3/3] x86/unwind/orc: Simplify unwind_init() for x86 boot Huaixin Chang
2020-08-19 3:03 ` [PATCH v2 0/3] Build ORC fast lookup table in scripts/sorttable tool changhuaixin
-- strict thread matches above, loose matches on Subject: below --
2020-06-01 17:38 [PATCH 0/2] " Josh Poimboeuf
2020-06-03 14:31 ` [PATCH v2 0/3] " Huaixin Chang
2020-06-03 14:31 ` [PATCH 1/3] scripts/sorttable: Change section type of orc_lookup to SHT_PROGBITS Huaixin Chang
2020-06-03 14:39 ` [PATCH v3 0/3] Build ORC fast lookup table in scripts/sorttable tool Huaixin Chang
2020-06-03 14:39 ` [PATCH 1/3] scripts/sorttable: Change section type of orc_lookup to SHT_PROGBITS Huaixin Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C605557D-951C-4FA7-9CE2-940B92FD198D@linux.alibaba.com \
--to=changhuaixin@linux.alibaba.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).