From: "박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)" <byungchul.park@lge.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "tj@kernel.org" <tj@kernel.org>,
"johannes.berg@intel.com" <johannes.berg@intel.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"oleg@redhat.com" <oleg@redhat.com>,
"david@fromorbit.com" <david@fromorbit.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-team@lge.com" <kernel-team@lge.com>
Subject: RE: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush
Date: Tue, 5 Sep 2017 16:36:18 +0900 [thread overview]
Message-ID: <C80AB6F618D91B4E8F391CB202C12DFD1ED20A9B30@LGEVEXMBHQSVC1.LGE.NET> (raw)
In-Reply-To: <20170905072551.fvtxrhuo662jiwif@hirez.programming.kicks-ass.net>
> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@infradead.org]
> Sent: Tuesday, September 05, 2017 4:26 PM
> To: Byungchul Park
> Cc: tj@kernel.org; johannes.berg@intel.com; mingo@kernel.org;
> tglx@linutronix.de; oleg@redhat.com; david@fromorbit.com; linux-
> kernel@vger.kernel.org; kernel-team@lge.com
> Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
> workqueue flush
>
> On Tue, Sep 05, 2017 at 11:29:14AM +0900, Byungchul Park wrote:
>
> > Also, lock_map_acquire() in process_one_work() is too strong for that
> > purpose. lock_map_acquire_might() is enough. Replaced it.
>
> NAK!! traditional annotations are superior to cross-release. They are not
> timing dependent.
You seem to mis-understand this. This also make them timing independent.
I also agree that we need timing independent report in workqueue code.
That's actually why I propose this patch.
I just tried to do it in a right way.
next prev parent reply other threads:[~2017-09-05 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 2:29 [PATCH 0/3] Fix the workqueue and lockdep annotation issue Byungchul Park
2017-09-05 2:29 ` [PATCH 1/3] lockdep: Use enum type on hlock->read instead of magic number Byungchul Park
2017-09-05 2:29 ` [PATCH 2/3] lockdep: Introduce lock_acquire_might() Byungchul Park
2017-09-05 7:22 ` Peter Zijlstra
2017-09-12 0:35 ` Byungchul Park
2017-09-26 0:58 ` Byungchul Park
2017-09-05 2:29 ` [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-09-05 7:25 ` Peter Zijlstra
2017-09-05 7:36 ` 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com) [this message]
2017-09-05 8:16 ` Peter Zijlstra
2017-09-05 8:19 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C80AB6F618D91B4E8F391CB202C12DFD1ED20A9B30@LGEVEXMBHQSVC1.LGE.NET \
--to=byungchul.park@lge.com \
--cc=david@fromorbit.com \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).