From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8F6C43144 for ; Mon, 25 Jun 2018 10:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 728CD25791 for ; Mon, 25 Jun 2018 10:43:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 728CD25791 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aosc.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755285AbeFYKnK convert rfc822-to-8bit (ORCPT ); Mon, 25 Jun 2018 06:43:10 -0400 Received: from hermes.aosc.io ([199.195.250.187]:45153 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755200AbeFYKnI (ORCPT ); Mon, 25 Jun 2018 06:43:08 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 44F7F632EA; Mon, 25 Jun 2018 10:43:00 +0000 (UTC) Date: Mon, 25 Jun 2018 18:42:30 +0800 In-Reply-To: <5B30A40D.3070509@broadcom.com> References: <20180315162510.11669-1-harald@ccbib.org> <20180315162510.11669-6-harald@ccbib.org> <5B309D37.80207@broadcom.com> <1CF519CD-D44E-4959-8951-27CE710E0984@aosc.io> <5B30A40D.3070509@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop To: Arend van Spriel , Harald Geyer CC: Maxime Ripard , Chen-Yu Tsai , Kalle Valo , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Przywara , info@olimex.com, linux-wireless@vger.kernel.org From: Icenowy Zheng Message-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年6月25日 GMT+08:00 下午4:13:01, Arend van Spriel 写到: >On 6/25/2018 9:47 AM, Icenowy Zheng wrote: >> >> >> 于 2018年6月25日 GMT+08:00 下午3:43:51, Arend van Spriel > 写到: >>> On 6/24/2018 6:34 PM, Harald Geyer wrote: >>>> Icenowy Zheng writes: >>>>>> 在 2018-03-15四的 16:25 +0000，Harald Geyer写道： >>>>>>>> +&mmc1 { >>>>>>>> + pinctrl-names = "default"; >>>>>>>> + pinctrl-0 = <&mmc1_pins>; >>>>>>>> + vmmc-supply = <®_aldo2>; >>>>>>>> + vqmmc-supply = <®_dldo4>; >>>>>>>> + mmc-pwrseq = <&wifi_pwrseq>; >>>>>>>> + bus-width = <4>; >>>>>>>> + non-removable; >>>>>>>> + status = "okay"; >>>>>>>> + >>>>>>>> + rtl8723bs: wifi@1 { >>>>>>>> + reg = <1>; >>>>>>>> + interrupt-parent = <&r_pio>; >>>>>>>> + interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ >>>>>>>> + interrupt-names = "host-wake"; >>>>>>>> + }; >>> >>> [...] >>> >>>>>> - This device node has no binding. The "host-wake" interrupt is >>> part of >>>>>> Broadcom SDIO Wi-Fi binding, rather than a generic one. >>>> I think the general mmc and interrupts bindings apply. And the mmc >>> binding >>>> clearly states that for sub-nodes a compatible string is optional. >>>> >>>> However I just realized that the 'interrupt-names' property is not >>> part >>>> of the general interrupts binding, so I guess at least this >property >>> should >>>> be removed. >>> >>> Indeed. If the device just used the SDIO interrupt this is not >needed. >>> The Broadcom device can use either SDIO interrupt or a so-called >>> out-of-band host-wake interrupt, which is what the above represents. >> >> RTL8....S is also capable of use OOB interrupt. > >Ok. Is it also in-place in this TERES-I laptop? Anyway, if RTL8...S In fact it's a regexp here, mean Realtek SDIO WLAN NICs. >does >not have a binding specification there is not much to do about it. In >my >opinion it does not make sense to add it to the generic mmc/sdio >binding >as this interrupt does not involve the mmc/sdio hardware hence the term > >OOB. There is generic wifi binding net/wireless/ieee80211.txt in which It seems ok. Maybe it can be used for all interfaces, not SDIO, although I don't think there's any other interfaces that can use OOB IRQ except SPI and SDIO, maybe UART? :-) >this could be added. Obviously it would just be a binding and no >guarantee that the actual device driver supports it so the RTL driver >would need modification for that. Yes. Currently OOB interrupt is not used at all. > >Regards, >Arend