drivers/of/unittest.c:910:1: warning: the frame size of 1424 bytes is larger than 1024 bytes

drivers/of/unittest.c:910:1: warning: the frame size of 1424 bytes is larger than 1024 bytes

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 6031 bytes --]

Hi Jim,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: e0d072782c734d27f5af062c62266f2598f68542 dma-mapping: introduce DMA range map, supplanting dma_pfn_offset
date:   1 year, 2 months ago
config: powerpc64-randconfig-r012-20211118 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e0d072782c734d27f5af062c62266f2598f68542
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout e0d072782c734d27f5af062c62266f2598f68542
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/of/unittest.c: In function 'of_unittest_dma_ranges_one.constprop':
>> drivers/of/unittest.c:910:1: warning: the frame size of 1424 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     910 | }
         | ^

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for HOTPLUG_PCI_POWERNV
   Depends on PCI && HOTPLUG_PCI && PPC_POWERNV && EEH
   Selected by
   - OCXL && PPC_POWERNV && PCI && EEH


vim +910 drivers/of/unittest.c

201c910bd6898d8 drivers/of/selftest.c Pantelis Antoniou 2014-07-04  871  
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  872  static void __init of_unittest_dma_ranges_one(const char *path,
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  873  		u64 expect_dma_addr, u64 expect_paddr)
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  874  {
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  875  #ifdef CONFIG_HAS_DMA
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  876  	struct device_node *np;
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  877  	const struct bus_dma_region *map = NULL;
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  878  	int rc;
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  879  
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  880  	np = of_find_node_by_path(path);
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  881  	if (!np) {
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  882  		pr_err("missing testcase data\n");
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  883  		return;
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  884  	}
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  885  
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  886  	rc = of_dma_get_range(np, &map);
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  887  
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  888  	unittest(!rc, "of_dma_get_range failed on node %pOF rc=%i\n", np, rc);
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  889  
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  890  	if (!rc) {
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  891  		phys_addr_t	paddr;
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  892  		dma_addr_t	dma_addr;
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  893  		struct device	dev_bogus;
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  894  
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  895  		dev_bogus.dma_range_map = map;
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  896  		paddr = dma_to_phys(&dev_bogus, expect_dma_addr);
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  897  		dma_addr = phys_to_dma(&dev_bogus, expect_paddr);
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  898  
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  899  		unittest(paddr == expect_paddr,
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  900  			 "of_dma_get_range: wrong phys addr %pap (expecting %llx) on node %pOF\n",
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  901  			 &paddr, expect_paddr, np);
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  902  		unittest(dma_addr == expect_dma_addr,
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  903  			 "of_dma_get_range: wrong DMA addr %pad (expecting %llx) on node %pOF\n",
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  904  			 &dma_addr, expect_dma_addr, np);
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  905  
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  906  		kfree(map);
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  907  	}
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  908  	of_node_put(np);
e0d072782c734d2 drivers/of/unittest.c Jim Quinlan       2020-09-17  909  #endif
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20 @910  }
04db93a95aef392 drivers/of/unittest.c Rob Herring       2019-09-20  911  

:::::: The code at line 910 was first introduced by commit
:::::: 04db93a95aef392a98f9ffa8745da2e7c58ba75b of/unittest: Add dma-ranges address translation tests

:::::: TO: Rob Herring <robh@kernel.org>
:::::: CC: Rob Herring <robh@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39259 bytes --]

Re: drivers/of/unittest.c:910:1: warning: the frame size of 1424 bytes is larger than 1024 bytes

[Christoph Hellwig]

I think we'll need to dynamically allocate the fake struct device here.
Jim, can you look into that?

Re: drivers/of/unittest.c:910:1: warning: the frame size of 1424 bytes is larger than 1024 bytes

[Jim Quinlan]

On Fri, Nov 19, 2021 at 1:11 AM Christoph Hellwig <hch@lst.de> wrote:
>
> I think we'll need to dynamically allocate the fake struct device here.
> Jim, can you look into that?

Hi Cristoph,

I don't remember seeing this warning before --- I will take care  of it.

BTW, IIRC you asked me to clean up the Broadcom MIPs PCIe DMA usage
code a while ago; we did,  but we observed some regressions when
testing old devices and put it on the backburner.  I think I will have
time in the near future to complete this once and for all.

Regards,
Jim Quinlan
Broadcom STB