From: Jim Quinlan <james.quinlan@broadcom.com>
To: Al Cooper <alcooperx@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
Jim Quinlan <jquinlan@broadcom.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE"
<devicetree@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271
Date: Mon, 23 Nov 2020 15:14:43 -0500 [thread overview]
Message-ID: <CA+-6iNxyrsnDb_O4Kdo34i_+E+bX=ro6-uDfUS-ziFx+Ee0d=A@mail.gmail.com> (raw)
In-Reply-To: <CA+-6iNxteaMui4XdC-eMctguuZs3T-G85UMuwa7fNUCkJqE1Cw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]
On Mon, Nov 23, 2020 at 10:58 AM Jim Quinlan <james.quinlan@broadcom.com> wrote:
>
> On Fri, Nov 20, 2020 at 2:45 PM Al Cooper <alcooperx@gmail.com> wrote:
> >
> > From: Jim Quinlan <jquinlan@broadcom.com>
> >
> > This commit has of_platform_serial_probe() check specifically for the
> > "brcm,bcm7271-uart" and whether its companion driver is enabled. If it
> > is the case, and the clock provider is not ready, we want to make sure
> > that when the 8250_bcm7271.c driver returns EPROBE_DEFER, we are not
> > getting the UART registered via 8250_of.c.
> >
> > Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
> > ---
> > drivers/tty/serial/8250/8250_of.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
> > index 65e9045dafe6..aa458f3c6644 100644
> > --- a/drivers/tty/serial/8250/8250_of.c
> > +++ b/drivers/tty/serial/8250/8250_of.c
> > @@ -192,6 +192,10 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
> > u32 tx_threshold;
> > int ret;
> >
> > + if (IS_ENABLED(CONFIG_SERIAL_8250_BCM7271) &&
> > + of_device_is_compatible(ofdev->dev.of_node, "brcm,bcm7271-uart"))
> > + return -ENODEV;
> > +
> NOTE: this commit is a "strawman" commit, and I will not be surprised
> if it gets quickly NAKed. We have a new idea on how to solve this
> issue, and if that not is not viable, will ask for a dialog on this
> problem either in this thread or through a separate RFC.
This commit is no longer needed as part of this patchset; we have
addressed the problem elsewhere. Sorry about the noise.
>
>
> Regards,
> Jim Quinlan
> Broadcom STB
>
>
>
> > port_type = (unsigned long)of_device_get_match_data(&ofdev->dev);
> > if (port_type == PORT_UNKNOWN)
> > return -EINVAL;
> > --
> > 2.17.1
> >
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4167 bytes --]
next prev parent reply other threads:[~2020-11-23 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 19:43 [PATCH 0/3] serial: 8250: Add driver for Broadcom UART Al Cooper
2020-11-20 19:43 ` [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271 Al Cooper
2020-11-23 15:58 ` Jim Quinlan
2020-11-23 20:14 ` Jim Quinlan [this message]
2020-11-26 8:29 ` Greg Kroah-Hartman
2020-11-20 19:43 ` [PATCH 2/3] dt-bindings: Add support for the Broadcom UART driver Al Cooper
2020-11-20 21:04 ` Rob Herring
2020-11-20 19:43 ` [PATCH 3/3] serial: 8250: Add new 8250-core based Broadcom STB driver Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+-6iNxyrsnDb_O4Kdo34i_+E+bX=ro6-uDfUS-ziFx+Ee0d=A@mail.gmail.com' \
--to=james.quinlan@broadcom.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jquinlan@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).