From: Tim Lewis <elatllat@gmail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com,
Christian Hewitt <christianshewitt@gmail.com>,
joy.cho@hardkernel.com, tobetter <tobetter@gmail.com>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
mark.rutland@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH v3] arm64: dts: meson: S922X: extend cpu opp-points
Date: Sun, 26 Apr 2020 12:18:54 -0400 [thread overview]
Message-ID: <CA+3zgmsVK9Uuv947-pniByP7QJVGcVK_EgiRkFipV5CUx70sHQ@mail.gmail.com> (raw)
In-Reply-To: <8255d8b1-f652-9ece-67d2-68c30a5cfbac@baylibre.com>
Oops, will fix in v4.
On Thu, Apr 23, 2020 at 3:40 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 23/04/2020 01:39, Tim Lewis wrote:
> > HardKernel supports overclock through the addition to extra opp points
> > in their official kernel sources for odroid-n2 [1]. Christian tested
> > on other S922X devices with "no obvious issues". Neil thinks dvfs and
> > thermal managementis can keep other S922X devices safe.
> --------------/\
> management
>
> >
> > [1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
> > Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> > Signed-off-by: Tim Lewis <elatllat@gmail.com>
> >
> > ---
> > arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
> > 1 files changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> > index 046cc332d..1e5d0ee5d 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> > @@ -65,6 +65,11 @@
> > opp-hz = /bits/ 64 <1896000000>;
> > opp-microvolt = <981000>;
> > };
> > +
> > + opp-1992000000 {
> > + opp-hz = /bits/ 64 <1992000000>;
> > + opp-microvolt = <1001000>;
> > + };
> > };
> >
> > cpub_opp_table_1: opp-table-1 {
> > @@ -120,5 +125,15 @@
> > opp-hz = /bits/ 64 <1704000000>;
> > opp-microvolt = <891000>;
> > };
> > +
> > + opp-1800000000 {
> > + opp-hz = /bits/ 64 <1800000000>;
> > + opp-microvolt = <981000>;
> > + };
> > +
> > + opp-1908000000 {
> > + opp-hz = /bits/ 64 <1908000000>;
> > + opp-microvolt = <1022000>;
> > + };
> > };
> > };
> >
>
> The patch is well formed but I can only test on Odroid-N2.
>
> Anyway, Christian did a test other S922X boxes and it doesn't crash.
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Neil
prev parent reply other threads:[~2020-04-26 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 23:39 [PATCH v3] arm64: dts: meson: S922X: extend cpu opp-points Tim Lewis
2020-04-23 7:40 ` Neil Armstrong
2020-04-26 16:18 ` Tim Lewis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+3zgmsVK9Uuv947-pniByP7QJVGcVK_EgiRkFipV5CUx70sHQ@mail.gmail.com \
--to=elatllat@gmail.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=joy.cho@hardkernel.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).