From: Linus Torvalds <email@example.com> To: Corey Minyard <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, firstname.lastname@example.org, Linux Kernel <email@example.com>, OpenIPMI Developers <firstname.lastname@example.org> Subject: Re: [PATCH 4/5] IPMI: Fix some uninitialized warning Date: Fri, 26 Oct 2012 12:41:13 -0700 [thread overview] Message-ID: <CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com> (raw) In-Reply-To: <508AE611.email@example.com> On Fri, Oct 26, 2012 at 12:35 PM, Corey Minyard <firstname.lastname@example.org> wrote: > > I'll do a patch to switch it to uninitialized_var() for the next set of > things I send. Thanks. Actually, I'm seriously considering getting rid of uninitialized_var(). The thing is an abomination, and we've already had one bug due to it (real uninitialized variable that was incorrectly hidden by uninitialized_var()). The thing is moronic. The whole thing is almost entirely due to compiler bugs (*stupid* gcc behavior), and we would have been better off with an explicit (unnecessary) initialization that at least doesn't cause random crashes etc if it turns out to be wrong. So please don't use that abortion. Just initialize things to 0/NULL/whatever if gcc complains and you want to get rid of them. Better than the crap that is uninitialized_var(), which just causes silent random behavior if it is wrong. Linus
next prev parent reply other threads:[~2012-10-26 19:41 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-16 20:53 IPMI: Some minor fixes minyard 2012-10-16 20:53 ` [PATCH 1/5] IPMI: Remove SMBus driver info from the docs minyard 2012-10-16 20:53 ` [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers minyard 2012-10-22 23:45 ` Andrew Morton 2012-10-23 0:00 ` Matthew Garrett 2012-10-23 0:07 ` Andrew Morton 2012-10-23 0:10 ` Matthew Garrett 2012-10-16 20:53 ` [PATCH 3/5] IPMI: Change link order minyard 2012-10-16 20:53 ` [PATCH 4/5] IPMI: Fix some uninitialized warning minyard 2012-10-22 23:49 ` Andrew Morton 2012-10-26 19:35 ` Corey Minyard 2012-10-26 19:41 ` Linus Torvalds [this message] 2012-10-27 13:12 ` [PATCH] Remove uninitialized_var() Ingo Molnar 2012-10-27 18:48 ` Andrew Morton 2012-10-28 10:20 ` [PATCH v2] " Ingo Molnar 2012-10-29 0:56 ` Ryan Mallon 2012-10-29 6:36 ` [PATCH v3] " Ingo Molnar 2012-10-29 18:55 ` [PATCH v2] " David Rientjes 2012-10-30 7:24 ` Ingo Molnar 2012-10-16 20:53 ` [PATCH 5/5] IPMI: Detect register spacing on PCI interfaces minyard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 4/5] IPMI: Fix some uninitialized warning' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).