From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934622AbcLOA0l (ORCPT ); Wed, 14 Dec 2016 19:26:41 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:33334 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbcLOA0j (ORCPT ); Wed, 14 Dec 2016 19:26:39 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161214035927.30004-1-Jason@zx2c4.com> <20161214184605.24006-1-Jason@zx2c4.com> From: Linus Torvalds Date: Wed, 14 Dec 2016 16:10:57 -0800 X-Google-Sender-Auth: 7Uami7f-x73FPU2lj_kgaAG6o48 Message-ID: Subject: Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function To: "Jason A. Donenfeld" Cc: Tom Herbert , Netdev , "kernel-hardening@lists.openwall.com" , LKML , Linux Crypto Mailing List , Jean-Philippe Aumasson , "Daniel J . Bernstein" , Eric Biggers , David Laight Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 3:34 PM, Jason A. Donenfeld wrote: > > Or does your reasonable dislike of "word" still allow for the use of > dword and qword, so that the current function names of: dword really is confusing to people. If you have a MIPS background, it means 64 bits. While to people with Windows programming backgrounds it means 32 bits. Please try to avoid using it. As mentioned, I think almost everybody agrees on the "q" part being 64 bits, but that may just be me not having seen it in any other context. And before anybody points it out - yes, we already have lots of uses of "dword" in various places. But they tend to be mostly hardware-specific - either architectures or drivers. So I'd _prefer_ to try to keep "word" and "dword" away from generic helper routines. But it's not like anything is really black and white. Linus