From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756224AbdKOAEo (ORCPT ); Tue, 14 Nov 2017 19:04:44 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:56573 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbdKOAEd (ORCPT ); Tue, 14 Nov 2017 19:04:33 -0500 X-Google-Smtp-Source: AGs4zMZ5i0hYVNDUCdOpzzycC/0e+dHdevvQJNE4MKffdBa53cCIaQEDEOs+j7gDuQQj1vlPd2rZJKOePBehBa37PEc= MIME-Version: 1.0 In-Reply-To: References: <20171109103814.70688-1-chao.wang@ucloud.cn> <2101739.Je3pS2vcJU@aspire.rjw.lan> From: Linus Torvalds Date: Tue, 14 Nov 2017 16:04:32 -0800 X-Google-Sender-Auth: TzVZmV92t10h-kt-88BFklBCqIw Message-ID: Subject: Re: [PATCH] x86: use cpufreq_quick_get() for /proc/cpuinfo "cpu MHz" again To: Thomas Gleixner Cc: "Rafael J. Wysocki" , WANG Chao , Linux Kernel Mailing List , Ingo Molnar , "H. Peter Anvin" , Vikas Shivappa , Kate Stewart , Len Brown , Greg Kroah-Hartman , Philippe Ombredanne , Mathias Krause , "the arch/x86 maintainers" , Linux PM , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 3:53 PM, Thomas Gleixner wrote: > Current head + Raphaels patch: > > real 0m0.029s > user 0m0.000s > sys 0m0.010s > > So that patch is actually slower. Oh it definitely is expected to be slower, because it does the IPI to all the cores and actually gets their frequency right. It was the old one that we had to revert (because it did so sequentially) that was really bad, and took something like 2+ seconds on Ingo's 160-core thing, iirc. It sounds like the current patch is slower, but likely acceptable considering that you get the right results now .. Linus