Re: [GIT PULL] HID fixes

From: Linus Torvalds <torvalds@linux-foundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Julian Sax <jsbc@gmx.de>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] HID fixes
Date: Wed, 20 Jun 2018 16:12:24 +0900	[thread overview]
Message-ID: <CA+55aFwCt9WZoBHEbsR65h=BRJ-GhqwWgU87wd2o4A_TzxQW2Q@mail.gmail.com> (raw)
In-Reply-To: <b952c1f6-5866-d25e-32c2-ac0ded1812e2@redhat.com>

On Wed, Jun 20, 2018 at 4:06 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
>
> Julian let me know if you need any help with this,
> to format the HID descriptor take a file with
> the raw descriptor in binary format and do:
>
> cat descriptor.bin | hidrd-convert -o code

But what is the *source* of this binary crud?

Because no way in hell do we take binary crud from random places, and
then add it to the kernel.

NOT EVEN IF IT WENT THROUGH SOME "hidrd-convert" PHASE!

And yes, now that I google for that hidrd-convert pattern, I see that
we already have other broken chunks like this.

Not ok. At least some of them seem to mention where the data comes from, eg

   "This is the original report descriptor as reported by lsusb -vd 046d:c294"

but this one has no such information.

So guys, you need to think about where things come from, and document
how some random garbage came to be. Not just add it to the kernel.

                     Linus