From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754486AbcEPSvN (ORCPT ); Mon, 16 May 2016 14:51:13 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:37226 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754317AbcEPSvL (ORCPT ); Mon, 16 May 2016 14:51:11 -0400 MIME-Version: 1.0 In-Reply-To: <20160502103101.20878.qmail@ns.horizon.com> References: <20160502102016.17936.qmail@ns.horizon.com> <20160502103101.20878.qmail@ns.horizon.com> Date: Mon, 16 May 2016 11:51:04 -0700 X-Google-Sender-Auth: gMCn2KdZKPsyCWyPTIhSIuldUdU Message-ID: Subject: Re: [RFC PATCH 4/2] namei: Improve hash mixing if CONFIG_DCACHE_WORD_ACCESS From: Linus Torvalds To: George Spelvin Cc: Linux Kernel Mailing List , Thomas Gleixner , Eric Dumazet , Rik van Riel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 2, 2016 at 3:31 AM, George Spelvin wrote: > The hash mixing between adding the next 64 bits of name > was just a bit weak. > > Replaced with a still very fast but slightly more effective > mixing function. I'e applied this patch independently of all your other hash rework to my tree. I verified that the code generation for the inner loop is still fine, and it does look like a much better mixing function, as well as just clean up the code. I hope to get new versions of the actual fixes during this merge window from you. Thanks, Linus