From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754992Ab2IFCr0 (ORCPT ); Wed, 5 Sep 2012 22:47:26 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33257 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315Ab2IFCrZ (ORCPT ); Wed, 5 Sep 2012 22:47:25 -0400 MIME-Version: 1.0 In-Reply-To: <20120905173011.7a1111f0@pyramind.ukuu.org.uk> References: <20120905140304.5c5c58a4@pyramind.ukuu.org.uk> <20120905173011.7a1111f0@pyramind.ukuu.org.uk> From: Linus Torvalds Date: Wed, 5 Sep 2012 19:47:03 -0700 X-Google-Sender-Auth: 3rVthRw_BQZqR68u_ZkzQpVlZ9U Message-ID: Subject: Re: A workaround for request_firmware() stuck in module_init To: Alan Cox Cc: Ming Lei , Takashi Iwai , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kay Sievers , linux-kernel@vger.kernel.org, Benjamin Herrenschmidt Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 5, 2012 at 9:30 AM, Alan Cox wrote: > > It's not about a workaround but about doing it properly for the long term > and doing it in one place. It's also not a "great change", its a small > change. udev needs to get fixed regardless. Stop this "we can break stuff" crap. Who maintains udev? Regressions are not acceptable. I'm not going to change the kernel because udev broke, f*ck it. Seriously. More projects need to realize that regressions are totally and utterly unacceptable. The "long term cleaner issues" can be handled separately, but are *not* an excuse to work around clear regressions in core packages. That just encourages those package maintainers to be shit maintainers. Just fix udev, which had a regression. And stop blaming the kernel for user space breakage! Tying these kinds of things together ("udev broke, so now we need to change the kernel") is *wrong*. It's totally unacceptable to tie the two together that way. Linus