From: Linus Torvalds <torvalds@linux-foundation.org>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Borislav Petkov <bp@alien8.de>,
Andrew Lutomriski <amluto@gmail.com>,
Dirk Hohndel <dirk@hohndel.org>,
Arjan van de Ven <arjan.van.de.ven@intel.com>,
comex <comexk@gmail.com>,
Alexander van Heukelum <heukelum@fastmail.fm>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] x86-64, espfix: Don't leak bits 31:16 of %esp returning to 16-bit stack
Date: Tue, 29 Apr 2014 17:57:11 -0700 [thread overview]
Message-ID: <CA+55aFwTKzSgt2fk8gYbA67hfEWV6_a18Dfhw2D9jzHzs2GSEg@mail.gmail.com> (raw)
In-Reply-To: <1398816946-3351-1-git-send-email-hpa@linux.intel.com>
On Tue, Apr 29, 2014 at 5:15 PM, H. Peter Anvin <hpa@linux.intel.com> wrote:
>
> Linus, this is technically a (functionality) regression fix. Will you
> want this for 3.15?
Too scary. If people complain, I think we should just replace the
if (!ldt_info.seg_32bit) {
with something like
if (!ldt_info.seg_32bit && !sysctl_allow_16bit_segments) {
and handle the regression that way.
Then, after way more testing, maybe we can backport the espfix thing.
Linus
next prev parent reply other threads:[~2014-04-30 0:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 0:15 [PATCH] x86-64, espfix: Don't leak bits 31:16 of %esp returning to 16-bit stack H. Peter Anvin
2014-04-30 0:57 ` Linus Torvalds [this message]
2014-04-30 10:38 ` Borislav Petkov
2014-04-30 16:18 ` H. Peter Anvin
2014-04-30 16:33 ` H. Peter Anvin
2014-04-30 17:16 ` Borislav Petkov
2014-04-30 17:25 ` H. Peter Anvin
2014-04-30 21:18 ` [tip:x86/espfix] x86-64, espfix: Don't leak bits 31: 16 " tip-bot for H. Peter Anvin
2014-04-30 21:19 ` [tip:x86/espfix] x86-32, espfix: Remove filter for espfix32 due to race tip-bot for H. Peter Anvin
2014-05-04 17:07 ` [tip:x86/espfix] x86, espfix: Make espfix64 a Kconfig option, fix UML tip-bot for H. Peter Anvin
2014-05-04 19:03 ` [tip:x86/espfix] x86, espfix: Make it possible do disable 16-bit support tip-bot for H. Peter Anvin
2014-05-04 19:30 ` [tip:x86/espfix] x86, espfix: Make it possible to " tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFwTKzSgt2fk8gYbA67hfEWV6_a18Dfhw2D9jzHzs2GSEg@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=amluto@gmail.com \
--cc=arjan.van.de.ven@intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=comexk@gmail.com \
--cc=dirk@hohndel.org \
--cc=heukelum@fastmail.fm \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).