linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Peter Hutterer <peter.hutterer@who-t.net>,
	Andrew Duggan <aduggan@synaptics.com>,
	Jiri Kosina <jikos@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] HID for 4.11
Date: Wed, 1 Mar 2017 09:54:07 -0800	[thread overview]
Message-ID: <CA+55aFwWpp1X6RhM94Qsb0BLikmcxVv9da9R0Zyoc9UWXe9jVA@mail.gmail.com> (raw)
In-Reply-To: <20170301090347.GE7064@mail.corp.redhat.com>

On Wed, Mar 1, 2017 at 1:03 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
>
> As Peter mentioned in the bug, there is a missing property on the kernel
> node (INPUT_PROP_BUTTONPAD).
>
> The thing is this property is solely driven in the current driver by the
> provided platform_data, so there is no way we ever set it through
> hid-rmi. I wonder how we missed that.
>
> Anyway, the good news is that the evemu record shows only one exportted
> button, so we can infer the property quite easily in the module. Would
> something like that work for you?
>
> From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Date: Wed, 1 Mar 2017 09:57:00 +0100
> Subject: [PATCH] Input: rmi4 - f30: detect INPUT_PROP_BUTTONPAD from the button count

Yes, this fixes the problem for me. My click-and-drag works again, so
you can add a

  Reported-and-tested-by: Linus Torvalds <torvalds@linux-foundation.org>

I see that Dmitry doesn't love the patch, but I'm assuming I'll get
that or something equivalent soon. In the meantime, I'll just keep it
on my laptop as a workaround.

Thanks,

                   Linus

  parent reply	other threads:[~2017-03-01 18:58 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 15:20 [GIT PULL] HID for 4.11 Jiri Kosina
2017-02-21  2:48 ` Linus Torvalds
2017-02-21  3:03   ` Linus Torvalds
2017-02-21  3:19     ` Linus Torvalds
2017-02-21  4:13     ` Linus Torvalds
2017-02-21  4:37       ` Linus Torvalds
2017-03-01  0:56         ` Linus Torvalds
2017-03-01  2:31           ` Andrew Duggan
2017-03-01  3:24             ` Peter Hutterer
2017-03-01  5:05               ` Linus Torvalds
2017-03-01  7:43                 ` Andrew Duggan
2017-03-01  9:03                 ` Benjamin Tissoires
2017-03-01  9:06                   ` Benjamin Tissoires
2017-03-01 17:31                     ` Dmitry Torokhov
2017-03-01 17:54                   ` Linus Torvalds [this message]
2017-03-01 17:58                     ` Dmitry Torokhov
2017-03-01 18:02                       ` Linus Torvalds
2017-02-21 14:17       ` [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not built (was Re: [GIT PULL] HID for 4.11) Jiri Kosina
2017-02-21 15:43         ` Linus Torvalds
2017-02-21 15:46           ` Jiri Kosina
2017-02-21 15:49             ` Linus Torvalds
2017-02-21 17:42               ` Benjamin Tissoires
2017-02-21 21:03                 ` Jiri Kosina
2017-02-22  0:53                   ` Jason Gerecke
2017-02-21 17:37         ` Benjamin Tissoires
2017-02-21 21:16         ` Andrew Duggan
2017-02-21  9:32   ` ath10k regression on XPS13 Kalle Valo
2017-02-21 18:18     ` David Miller
2017-02-21 18:38       ` Kalle Valo
2017-02-21 18:53         ` David Miller
2017-02-21 19:49           ` Kalle Valo
2017-02-21 21:00             ` David Miller
2017-02-21 18:52       ` Linus Torvalds
2017-02-21 21:01         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFwWpp1X6RhM94Qsb0BLikmcxVv9da9R0Zyoc9UWXe9jVA@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=aduggan@synaptics.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).