From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755627AbcJZSS6 (ORCPT ); Wed, 26 Oct 2016 14:18:58 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35825 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754865AbcJZSSy (ORCPT ); Wed, 26 Oct 2016 14:18:54 -0400 MIME-Version: 1.0 In-Reply-To: <20161024184739.GB2125@cmpxchg.org> References: <20161019172428.7649-1-hannes@cmpxchg.org> <20161024184739.GB2125@cmpxchg.org> From: Linus Torvalds Date: Wed, 26 Oct 2016 11:18:52 -0700 X-Google-Sender-Auth: C1a8RH0msnxNeBDHw9io4PWDD4g Message-ID: Subject: Re: [PATCH 0/5] mm: workingset: radix tree subtleties & single-page file refaults To: Johannes Weiner Cc: Andrew Morton , Jan Kara , Dave Jones , linux-mm , Linux Kernel Mailing List , kernel-team Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2016 at 11:47 AM, Johannes Weiner wrote: > > How about this instead: given that we already mark the shadow entries > exceptional, and the exceptional bit is part of the radix tree API, > can we just introduce a node->exceptional counter for those entries > and have the radix tree code assist us with that instead? It adds the > counting for non-shadow exceptional entries as well (shmem swap slots, > and DAX non-page entries), unfortunately, but this is way cleaner. It > also makes mapping->nrexceptional and node->exceptional consistent in > DAX (Jan, could you please double check the accounting there?) > > What do you think? Lightly tested patch below. This certainly looks way better to me. I didn't *test* it, but it doesn't make me scratch my head the way your previous patch did. Linus