From: Linus Torvalds <torvalds@linux-foundation.org>
To: Guenter Roeck <linux@roeck-us.net>,
Miklos Szeredi <miklos@szeredi.hu>, Helge Deller <deller@gmx.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>
Subject: Re: Linux 3.15-rc6
Date: Thu, 22 May 2014 17:43:34 -0700 [thread overview]
Message-ID: <CA+55aFw_kOE1Y4qkLW4rWfB_NaYYDwFeU=t5swsJCTMq-3J6nA@mail.gmail.com> (raw)
In-Reply-To: <20140522172032.GA20975@roeck-us.net>
Miklos,
this is from your commit 18e480aa07f78 ("parisc: add renameat2
syscall") which was acked by Helge Deller:
On Thu, May 22, 2014 at 10:20 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>
> Unfortunately it appears that the parisc changes cause build failures
> with parisc 64 bit builds.
>
> Building parisc:a500_defconfig ... failed
> Building parisc:generic-64bit_defconfig ... failed
>
> Error log:
> arch/parisc/kernel/built-in.o: In function `sys_call_table':
> (.rodata+0xad0): undefined reference to `compat_sys_renameat2'
> make: *** [vmlinux] Error 1
only s390 seems to need a compat wrapper, and s390 is kind of odd in
many respects, so I suspect renameat2 should just use ENTRY_SAME() on
parisc, but without any way to *test* it I won't apply the patch.
Guenter, I assume that changing the
ENTRY_COMP(renameat2)
line in arch/parisc/kernel/syscall_table.S to use ENTRY_SAME() at
least fixes the compile error?
Linus
next prev parent reply other threads:[~2014-05-23 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 22:47 Linux 3.15-rc6 Linus Torvalds
2014-05-22 17:20 ` Guenter Roeck
2014-05-23 0:43 ` Linus Torvalds [this message]
2014-05-23 1:07 ` Guenter Roeck
2014-05-23 1:27 ` Linus Torvalds
2014-05-23 9:12 ` Miklos Szeredi
2014-05-23 9:16 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFw_kOE1Y4qkLW4rWfB_NaYYDwFeU=t5swsJCTMq-3J6nA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).