From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Linux PM" <linux-pm@vger.kernel.org>,
"Linux ACPI" <linux-acpi@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Darren Hart" <dvhart@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@dell.com>,
"Tom Lanyon" <tom@oneshoeco.com>,
"Jérôme de Bretagne" <jerome.debretagne@gmail.com>
Subject: Re: [PATCH v2 3/3] ACPI / sleep: EC-based wakeup from suspend-to-idle on recent Dell systems
Date: Tue, 20 Jun 2017 08:07:11 +0800 [thread overview]
Message-ID: <CA+55aFwywLewxDenVcH1GxeigpS30B_+rvYh+=ff76EQpOcuOg@mail.gmail.com> (raw)
In-Reply-To: <2026371.DVJN39QYJi@aspire.rjw.lan>
On Tue, Jun 20, 2017 at 5:53 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> -> v2: Added acpi_sleep=no_ec_wakeup to prevent EC events from waking up
> the system from s2idle on systems where they do that by default.
This seems a big hacky.
Is there no way to simply make acpi_ec_suspend() smarter while going
to sleep? Instead of just unconditionally disabling every EC GPE, can
we see that "this gpe is the power botton" somehow?
Disabling the power button event sounds fundamentally broken, and it
sounds like Windows doesn't do that. I doubt Windows has some hacky
whitelist. So I'd rather fix a deeper issue than have these kinds of
hacks, if at all possible.
Linus
next prev parent reply other threads:[~2017-06-20 0:07 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 21:21 [PATCH 0/5] PM / sleep: Support power button wakeup from S2I on recent Dell laptops Rafael J. Wysocki
2017-04-26 21:22 ` [PATCH 1/5] PM / wakeup: Integrate mechanism to abort transitions in progress Rafael J. Wysocki
2017-04-26 21:23 ` [PATCH 2/5] ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle Rafael J. Wysocki
2017-04-26 21:24 ` [PATCH 3/5] ACPI / sleep: EC-based wakeup from suspend-to-idle on Dell systems Rafael J. Wysocki
2017-04-27 14:47 ` Mario.Limonciello
2017-04-27 22:26 ` Rafael J. Wysocki
2017-05-04 7:58 ` Zheng, Lv
2017-05-04 14:23 ` Rafael J. Wysocki
2017-05-04 14:26 ` Rafael J. Wysocki
2017-05-05 0:36 ` Zheng, Lv
2017-04-26 21:24 ` [PATCH 4/5] platform: x86: intel-vbtn: Wake up the system from suspend-to-idle Rafael J. Wysocki
2017-04-26 21:27 ` [PATCH 5/5] platform: x86: intel-hid: " Rafael J. Wysocki
2017-05-04 14:33 ` [PATCH 0/5] PM / sleep: Support power button wakeup from S2I on recent Dell laptops Rafael J. Wysocki
2017-05-31 23:23 ` [PATCH 0/3] ACPI " Rafael J. Wysocki
2017-05-31 23:24 ` [PATCH 1/3] platform: x86: intel-vbtn: Wake up the system from suspend-to-idle Rafael J. Wysocki
2017-05-31 23:26 ` [PATCH 2/3] platform: x86: intel-hid: " Rafael J. Wysocki
2017-05-31 23:27 ` [PATCH 3/3] ACPI / sleep: EC-based wakeup from suspend-to-idle on recent Dell systems Rafael J. Wysocki
2017-06-05 15:18 ` Mario.Limonciello
2017-06-05 20:51 ` Rafael J. Wysocki
2017-06-01 10:43 ` [PATCH 0/3] ACPI / sleep: Support power button wakeup from S2I on recent Dell laptops Andy Shevchenko
2017-06-01 11:50 ` Tom Lanyon
2017-06-01 14:59 ` Rafael J. Wysocki
2017-06-02 1:06 ` Tom Lanyon
2017-06-02 23:16 ` Rafael J. Wysocki
2017-06-01 15:00 ` Rafael J. Wysocki
2017-06-19 21:48 ` [PATCH v2 " Rafael J. Wysocki
2017-06-19 21:49 ` [PATCH v2 1/3] platform: x86: intel-vbtn: Wake up the system from suspend-to-idle Rafael J. Wysocki
2017-06-19 21:51 ` [PATCH v2 2/3] platform: x86: intel-hid: " Rafael J. Wysocki
2017-06-19 21:53 ` [PATCH v2 3/3] ACPI / sleep: EC-based wakeup from suspend-to-idle on recent Dell systems Rafael J. Wysocki
2017-06-19 23:37 ` Zheng, Lv
2017-06-19 23:46 ` Rafael J. Wysocki
2017-06-21 1:13 ` Zheng, Lv
2017-06-20 0:07 ` Linus Torvalds [this message]
2017-06-20 1:13 ` Rafael J. Wysocki
2017-06-20 2:00 ` Linus Torvalds
2017-06-20 21:16 ` Rafael J. Wysocki
2017-06-21 1:13 ` Zheng, Lv
2017-06-22 23:56 ` [PATCH] ACPI / sleep: EC-based wakeup from suspend-to-idle on recent systems Rafael J. Wysocki
2017-06-23 2:40 ` Linus Torvalds
2017-06-27 5:50 ` Tom Lanyon
2017-06-27 6:47 ` Andy Shevchenko
2017-06-27 10:54 ` Tom Lanyon
2017-06-27 11:10 ` Mario.Limonciello
2017-06-27 15:03 ` Rafael J. Wysocki
2017-06-27 16:14 ` Srinivas Pandruvada
2017-07-06 11:41 ` Tom Lanyon
2017-07-07 0:38 ` Srinivas Pandruvada
2017-06-23 6:30 ` Zheng, Lv
2017-06-23 12:13 ` Rafael J. Wysocki
2017-06-23 12:27 ` Rafael J. Wysocki
2017-06-23 13:15 ` [PATCH v2] " Rafael J. Wysocki
2017-06-23 15:37 ` Mario.Limonciello
2017-06-23 16:06 ` Srinivas Pandruvada
2017-06-23 18:01 ` Mario.Limonciello
2017-06-24 0:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwywLewxDenVcH1GxeigpS30B_+rvYh+=ff76EQpOcuOg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=jerome.debretagne@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tom@oneshoeco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).