From: Linus Torvalds <torvalds@linux-foundation.org>
To: Behan Webster <behanw@converseincode.com>
Cc: Alasdair G Kergon <agk@redhat.com>, Chris Mason <clm@fb.com>,
David Miller <davem@davemloft.net>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Fabian Frederick <fabf@skynet.be>,
Herbert Xu <herbert@gondor.apana.org.au>,
Josef Bacik <jbacik@fb.com>, Mike Snitzer <snitzer@redhat.com>,
tadeusz.struk@intel.com,
Andrew Morton <akpm@linux-foundation.org>,
Bruce Allan <bruce.w.allan@intel.com>,
Dmitry Kasatkin <d.kasatkin@samsung.com>,
James Morris <james.l.morris@oracle.com>,
john.griffin@intel.com, linux-btrfs <linux-btrfs@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
linux-ima-devel@lists.sourceforge.net,
linux-ima-user@lists.sourceforge.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
LSM List <linux-security-module@vger.kernel.org>,
Neil Brown <neilb@suse.de>,
qat-linux@intel.com, "Serge E. Hallyn" <serge@hallyn.com>,
thomas.lendacky@amd.com, Mimi Zohar <zohar@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c
Date: Mon, 15 Sep 2014 07:21:46 -0700 [thread overview]
Message-ID: <CA+55aFx8FN2Rq+d3v9rsDbTyX3hwm6TvudvZrL5wgf7fX3aQjA@mail.gmail.com> (raw)
In-Reply-To: <1410766234-1634-12-git-send-email-behanw@converseincode.com>
On Mon, Sep 15, 2014 at 12:30 AM, <behanw@converseincode.com> wrote:
> From: Behan Webster <behanw@converseincode.com>
>
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This patch allocates the appropriate amount of memory
> using a char array using the SHASH_DESC_ON_STACK macro.
You only made the first case use SHASH_DESC_ON_STACK, the two other
cases you left in the ugly format. Was that just an oversight, or was
there some reason for it?
Linus
next prev parent reply other threads:[~2014-09-15 14:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 7:30 [PATCH v3 00/12] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM behanw
2014-09-15 7:30 ` [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code behanw
2014-09-15 8:06 ` [dm-devel] " Michał Mirosław
2014-09-15 8:37 ` Behan Webster
2014-09-17 9:22 ` Herbert Xu
2014-09-17 11:15 ` Dmitry Kasatkin
2014-09-17 11:30 ` Herbert Xu
2014-09-17 15:26 ` Behan Webster
2014-09-15 7:30 ` [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS behanw
2014-09-17 13:49 ` Chris Mason
2014-09-15 7:30 ` [PATCH v3 03/12] crypto: LLVMLinux: Remove VLAIS from crypto/ccp/ccp-crypto-sha.c behanw
2014-09-15 7:30 ` [PATCH v3 04/12] crypto: LLVMLinux: Remove VLAIS from crypto/mv_cesa.c behanw
2014-09-15 7:30 ` [PATCH v3 05/12] crypto: LLVMLinux: Remove VLAIS from crypto/n2_core.c behanw
2014-09-15 7:30 ` [PATCH v3 06/12] crypto: LLVMLinux: Remove VLAIS from crypto/omap_sham.c behanw
2014-09-15 7:30 ` [PATCH v3 07/12] crypto: LLVMLinux: Remove VLAIS from crypto/.../qat_algs.c behanw
2014-09-15 7:30 ` [PATCH v3 08/12] crypto, dm: LLVMLinux: Remove VLAIS usage from dm-crypt behanw
2014-09-15 7:30 ` [PATCH v3 09/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/hmac.c behanw
2014-09-15 7:30 ` [PATCH v3 10/12] crypto: LLVMLinux: Remove VLAIS usage from libcrc32c.c behanw
2014-09-15 7:30 ` [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c behanw
2014-09-15 14:21 ` Linus Torvalds [this message]
2014-09-15 14:25 ` Behan Webster
2014-09-15 7:30 ` [PATCH v3 12/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/testmgr.c behanw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFx8FN2Rq+d3v9rsDbTyX3hwm6TvudvZrL5wgf7fX3aQjA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=behanw@converseincode.com \
--cc=bruce.w.allan@intel.com \
--cc=clm@fb.com \
--cc=d.kasatkin@samsung.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=fabf@skynet.be \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jbacik@fb.com \
--cc=john.griffin@intel.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-ima-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=neilb@suse.de \
--cc=qat-linux@intel.com \
--cc=serge@hallyn.com \
--cc=snitzer@redhat.com \
--cc=tadeusz.struk@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).