From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754686Ab2AWWif (ORCPT ); Mon, 23 Jan 2012 17:38:35 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38424 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753347Ab2AWWid (ORCPT ); Mon, 23 Jan 2012 17:38:33 -0500 MIME-Version: 1.0 In-Reply-To: References: <1327139539-14301-1-git-send-email-yinghai@kernel.org> <1327139539-14301-2-git-send-email-yinghai@kernel.org> From: Linus Torvalds Date: Mon, 23 Jan 2012 14:38:12 -0800 X-Google-Sender-Auth: 6uKXv9dFlVSf45IYf4wBVHZAYCc Message-ID: Subject: Re: [PATCH 1/7] PCI: Make sriov work with hotplug remove To: Yinghai Lu Cc: Jesse Barnes , Kenji Kaneshige , Matthew Wilcox , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Rzeszutek Wilk Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2012 at 2:30 PM, Yinghai Lu wrote: > > for_each_prev_safe is working... > > please check attached patch... Ugh. This is probably the best one so far, but the whole thing is really confused. Why does "stop_bus_device" do a "remove" for VF's at _all_? Why is everything about those stupid virtual devices so screwed up? Why do we have separate "stop" and "remove" methods, and then the "stop" does a remove? WTF? Linus