From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757435AbcG1TIk (ORCPT ); Thu, 28 Jul 2016 15:08:40 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34486 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757229AbcG1TIi (ORCPT ); Thu, 28 Jul 2016 15:08:38 -0400 MIME-Version: 1.0 In-Reply-To: References: <20140616132045.GE8170@pd.tnic> <20140616211405.GA7914@ravnborg.org> <20140624213835.GD15068@pd.tnic> <20140707105339.GA4776@pd.tnic> <20160728042011.GA25498@nazgul.tnic> <20160728082915.GA2349@gmail.com> From: Linus Torvalds Date: Thu, 28 Jul 2016 12:08:37 -0700 X-Google-Sender-Auth: J1rxhTJzhkeW_utmFsRIqGZ8TPs Message-ID: Subject: Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 To: Ingo Molnar Cc: Borislav Petkov , Sam Ravnborg , lkml , Michael Matz , Linux Kbuild mailing list , x86-ml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 12:03 PM, Linus Torvalds wrote: > > Once we get to the point that the warning is no longer useful, and is > more pain than gain, it gets disabled. Btw, I have a suspicion that you didn't realize that "-Wmaybe-uninitialized" is separate from "-Wuninitialized" (which is *not* disabled). The "maybe-uninitialized" warning is literally gcc saying "I haven't really followed all the logic, but from my broken understanding it isn't _obvious_ that it is initialized". And the problem is that a lot of gcc optimization choices basically move the pointer of "obvious". So the warning is a bit random to begin with. And when the gcc people screw thigns up, things go to hell in a handbasket. Linus