From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756012AbbBLQBR (ORCPT ); Thu, 12 Feb 2015 11:01:17 -0500 Received: from mail-ie0-f179.google.com ([209.85.223.179]:37712 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755701AbbBLQBQ (ORCPT ); Thu, 12 Feb 2015 11:01:16 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 12 Feb 2015 08:01:15 -0800 X-Google-Sender-Auth: G04kiNZzBbJg5Y573tmG_OZafTM Message-ID: Subject: Re: frequent lockups in 3.18rc4 From: Linus Torvalds To: Martin van Es Cc: Linux Kernel Mailing List Content-Type: multipart/mixed; boundary=001a114100b0d1f0f0050ee63a69 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --001a114100b0d1f0f0050ee63a69 Content-Type: text/plain; charset=UTF-8 On Thu, Feb 12, 2015 at 3:09 AM, Martin van Es wrote: > > Best I can come up with now is try the next mainline that has all the > fixes and ideas in this thread incorporated. Would that be 3.19? Yes. I'm attaching a patch (very much experimental - it might introduce new problems rather than fix old ones) that might also be worth testing on top of 3.19. > I'm sorry I couldn't be more helpful. Hey, so far nobody else has been able to pin this down either. It seems to be very timing-specific, and it's possible (even likely, considering DaveJ's adventures) that while you cannot trigger it with 3.16.7, it might be lurking there too, just not with the kind of timing that can trigger it on your machine. Which would explain the bisection trouble. It would have been wonderful if somebody had been able to really reproduce it truly reliably, but it seems to be very slippery. Linus --001a114100b0d1f0f0050ee63a69 Content-Type: text/plain; charset=US-ASCII; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i62c2ncb0 IGtlcm5lbC9zbXAuYyB8IDc4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQ3IGluc2VydGlvbnMoKyks IDMxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2tlcm5lbC9zbXAuYyBiL2tlcm5lbC9zbXAu YwppbmRleCBmMzhhMWU2OTIyNTkuLjJhYWFjMmM0NzY4MyAxMDA2NDQKLS0tIGEva2VybmVsL3Nt cC5jCisrKyBiL2tlcm5lbC9zbXAuYwpAQCAtMTksNyArMTksNyBAQAogCiBlbnVtIHsKIAlDU0Rf RkxBR19MT0NLCQk9IDB4MDEsCi0JQ1NEX0ZMQUdfV0FJVAkJPSAweDAyLAorCUNTRF9GTEFHX1NZ TkNIUk9OT1VTCT0gMHgwMiwKIH07CiAKIHN0cnVjdCBjYWxsX2Z1bmN0aW9uX2RhdGEgewpAQCAt MTA3LDcgKzEwNyw3IEBAIHZvaWQgX19pbml0IGNhbGxfZnVuY3Rpb25faW5pdCh2b2lkKQogICov CiBzdGF0aWMgdm9pZCBjc2RfbG9ja193YWl0KHN0cnVjdCBjYWxsX3NpbmdsZV9kYXRhICpjc2Qp CiB7Ci0Jd2hpbGUgKGNzZC0+ZmxhZ3MgJiBDU0RfRkxBR19MT0NLKQorCXdoaWxlIChzbXBfbG9h ZF9hY3F1aXJlKCZjc2QtPmZsYWdzKSAmIENTRF9GTEFHX0xPQ0spCiAJCWNwdV9yZWxheCgpOwog fQogCkBAIC0xMjEsMTkgKzEyMSwxNyBAQCBzdGF0aWMgdm9pZCBjc2RfbG9jayhzdHJ1Y3QgY2Fs bF9zaW5nbGVfZGF0YSAqY3NkKQogCSAqIHRvIC0+ZmxhZ3Mgd2l0aCBhbnkgc3Vic2VxdWVudCBh c3NpZ25tZW50cyB0byBvdGhlcgogCSAqIGZpZWxkcyBvZiB0aGUgc3BlY2lmaWVkIGNhbGxfc2lu Z2xlX2RhdGEgc3RydWN0dXJlOgogCSAqLwotCXNtcF9tYigpOworCXNtcF93bWIoKTsKIH0KIAog c3RhdGljIHZvaWQgY3NkX3VubG9jayhzdHJ1Y3QgY2FsbF9zaW5nbGVfZGF0YSAqY3NkKQogewot CVdBUk5fT04oKGNzZC0+ZmxhZ3MgJiBDU0RfRkxBR19XQUlUKSAmJiAhKGNzZC0+ZmxhZ3MgJiBD U0RfRkxBR19MT0NLKSk7CisJV0FSTl9PTighKGNzZC0+ZmxhZ3MgJiBDU0RfRkxBR19MT0NLKSk7 CiAKIAkvKgogCSAqIGVuc3VyZSB3ZSdyZSBhbGwgZG9uZSBiZWZvcmUgcmVsZWFzaW5nIGRhdGE6 CiAJICovCi0Jc21wX21iKCk7Ci0KLQljc2QtPmZsYWdzICY9IH5DU0RfRkxBR19MT0NLOworCXNt cF9zdG9yZV9yZWxlYXNlKCZjc2QtPmZsYWdzLCAwKTsKIH0KIAogc3RhdGljIERFRklORV9QRVJf Q1BVX1NIQVJFRF9BTElHTkVEKHN0cnVjdCBjYWxsX3NpbmdsZV9kYXRhLCBjc2RfZGF0YSk7CkBA IC0xNDQsMTMgKzE0MiwxNiBAQCBzdGF0aWMgREVGSU5FX1BFUl9DUFVfU0hBUkVEX0FMSUdORUQo c3RydWN0IGNhbGxfc2luZ2xlX2RhdGEsIGNzZF9kYXRhKTsKICAqIC0+ZnVuYywgLT5pbmZvLCBh bmQgLT5mbGFncyBzZXQuCiAgKi8KIHN0YXRpYyBpbnQgZ2VuZXJpY19leGVjX3NpbmdsZShpbnQg Y3B1LCBzdHJ1Y3QgY2FsbF9zaW5nbGVfZGF0YSAqY3NkLAotCQkJICAgICAgIHNtcF9jYWxsX2Z1 bmNfdCBmdW5jLCB2b2lkICppbmZvLCBpbnQgd2FpdCkKKwkJCSAgICAgICBzbXBfY2FsbF9mdW5j X3QgZnVuYywgdm9pZCAqaW5mbykKIHsKLQlzdHJ1Y3QgY2FsbF9zaW5nbGVfZGF0YSBjc2Rfc3Rh Y2sgPSB7IC5mbGFncyA9IDAgfTsKLQl1bnNpZ25lZCBsb25nIGZsYWdzOwotCi0KIAlpZiAoY3B1 ID09IHNtcF9wcm9jZXNzb3JfaWQoKSkgeworCQl1bnNpZ25lZCBsb25nIGZsYWdzOworCisJCS8q CisJCSAqIFdlIGNhbiB1bmxvY2sgZWFybHkgZXZlbiBmb3IgdGhlIHN5bmNocm9ub3VzIG9uLXN0 YWNrIGNhc2UsCisJCSAqIHNpbmNlIHdlJ3JlIGRvaW5nIHRoaXMgZnJvbSB0aGUgc2FtZSBDUFUu LgorCQkgKi8KKwkJY3NkX3VubG9jayhjc2QpOwogCQlsb2NhbF9pcnFfc2F2ZShmbGFncyk7CiAJ CWZ1bmMoaW5mbyk7CiAJCWxvY2FsX2lycV9yZXN0b3JlKGZsYWdzKTsKQEAgLTE2MSwyMSArMTYy LDkgQEAgc3RhdGljIGludCBnZW5lcmljX2V4ZWNfc2luZ2xlKGludCBjcHUsIHN0cnVjdCBjYWxs X3NpbmdsZV9kYXRhICpjc2QsCiAJaWYgKCh1bnNpZ25lZCljcHUgPj0gbnJfY3B1X2lkcyB8fCAh Y3B1X29ubGluZShjcHUpKQogCQlyZXR1cm4gLUVOWElPOwogCi0KLQlpZiAoIWNzZCkgewotCQlj c2QgPSAmY3NkX3N0YWNrOwotCQlpZiAoIXdhaXQpCi0JCQljc2QgPSB0aGlzX2NwdV9wdHIoJmNz ZF9kYXRhKTsKLQl9Ci0KLQljc2RfbG9jayhjc2QpOwotCiAJY3NkLT5mdW5jID0gZnVuYzsKIAlj c2QtPmluZm8gPSBpbmZvOwogCi0JaWYgKHdhaXQpCi0JCWNzZC0+ZmxhZ3MgfD0gQ1NEX0ZMQUdf V0FJVDsKLQogCS8qCiAJICogVGhlIGxpc3QgYWRkaXRpb24gc2hvdWxkIGJlIHZpc2libGUgYmVm b3JlIHNlbmRpbmcgdGhlIElQSQogCSAqIGhhbmRsZXIgbG9ja3MgdGhlIGxpc3QgdG8gcHVsbCB0 aGUgZW50cnkgb2ZmIGl0IGJlY2F1c2Ugb2YKQEAgLTE5MCw5ICsxNzksNiBAQCBzdGF0aWMgaW50 IGdlbmVyaWNfZXhlY19zaW5nbGUoaW50IGNwdSwgc3RydWN0IGNhbGxfc2luZ2xlX2RhdGEgKmNz ZCwKIAlpZiAobGxpc3RfYWRkKCZjc2QtPmxsaXN0LCAmcGVyX2NwdShjYWxsX3NpbmdsZV9xdWV1 ZSwgY3B1KSkpCiAJCWFyY2hfc2VuZF9jYWxsX2Z1bmN0aW9uX3NpbmdsZV9pcGkoY3B1KTsKIAot CWlmICh3YWl0KQotCQljc2RfbG9ja193YWl0KGNzZCk7Ci0KIAlyZXR1cm4gMDsKIH0KIApAQCAt MjUwLDggKzIzNiwxNyBAQCBzdGF0aWMgdm9pZCBmbHVzaF9zbXBfY2FsbF9mdW5jdGlvbl9xdWV1 ZShib29sIHdhcm5fY3B1X29mZmxpbmUpCiAJfQogCiAJbGxpc3RfZm9yX2VhY2hfZW50cnlfc2Fm ZShjc2QsIGNzZF9uZXh0LCBlbnRyeSwgbGxpc3QpIHsKLQkJY3NkLT5mdW5jKGNzZC0+aW5mbyk7 Ci0JCWNzZF91bmxvY2soY3NkKTsKKwkJc21wX2NhbGxfZnVuY190IGZ1bmMgPSBjc2QtPmZ1bmM7 CisJCXZvaWQgKmluZm8gPSBjc2QtPmluZm87CisKKwkJLyogRG8gd2Ugd2FpdCB1bnRpbCAqYWZ0 ZXIqIGNhbGxiYWNrPyAqLworCQlpZiAoY3NkLT5mbGFncyAmIENTRF9GTEFHX1NZTkNIUk9OT1VT KSB7CisJCQlmdW5jKGluZm8pOworCQkJY3NkX3VubG9jayhjc2QpOworCQl9IGVsc2UgeworCQkJ Y3NkX3VubG9jayhjc2QpOworCQkJZnVuYyhpbmZvKTsKKwkJfQogCX0KIAogCS8qCkBAIC0yNzQs NiArMjY5LDggQEAgc3RhdGljIHZvaWQgZmx1c2hfc21wX2NhbGxfZnVuY3Rpb25fcXVldWUoYm9v bCB3YXJuX2NwdV9vZmZsaW5lKQogaW50IHNtcF9jYWxsX2Z1bmN0aW9uX3NpbmdsZShpbnQgY3B1 LCBzbXBfY2FsbF9mdW5jX3QgZnVuYywgdm9pZCAqaW5mbywKIAkJCSAgICAgaW50IHdhaXQpCiB7 CisJc3RydWN0IGNhbGxfc2luZ2xlX2RhdGEgKmNzZDsKKwlzdHJ1Y3QgY2FsbF9zaW5nbGVfZGF0 YSBjc2Rfc3RhY2sgPSB7IC5mbGFncyA9IENTRF9GTEFHX0xPQ0sgfCBDU0RfRkxBR19TWU5DSFJP Tk9VUyB9OwogCWludCB0aGlzX2NwdTsKIAlpbnQgZXJyOwogCkBAIC0yOTIsNyArMjg5LDE2IEBA IGludCBzbXBfY2FsbF9mdW5jdGlvbl9zaW5nbGUoaW50IGNwdSwgc21wX2NhbGxfZnVuY190IGZ1 bmMsIHZvaWQgKmluZm8sCiAJV0FSTl9PTl9PTkNFKGNwdV9vbmxpbmUodGhpc19jcHUpICYmIGly cXNfZGlzYWJsZWQoKQogCQkgICAgICYmICFvb3BzX2luX3Byb2dyZXNzKTsKIAotCWVyciA9IGdl bmVyaWNfZXhlY19zaW5nbGUoY3B1LCBOVUxMLCBmdW5jLCBpbmZvLCB3YWl0KTsKKwljc2QgPSAm Y3NkX3N0YWNrOworCWlmICghd2FpdCkgeworCQljc2QgPSB0aGlzX2NwdV9wdHIoJmNzZF9kYXRh KTsKKwkJY3NkX2xvY2soY3NkKTsKKwl9CisKKwllcnIgPSBnZW5lcmljX2V4ZWNfc2luZ2xlKGNw dSwgY3NkLCBmdW5jLCBpbmZvKTsKKworCWlmICh3YWl0KQorCQljc2RfbG9ja193YWl0KGNzZCk7 CiAKIAlwdXRfY3B1KCk7CiAKQEAgLTMyMSw3ICszMjcsMTUgQEAgaW50IHNtcF9jYWxsX2Z1bmN0 aW9uX3NpbmdsZV9hc3luYyhpbnQgY3B1LCBzdHJ1Y3QgY2FsbF9zaW5nbGVfZGF0YSAqY3NkKQog CWludCBlcnIgPSAwOwogCiAJcHJlZW1wdF9kaXNhYmxlKCk7Ci0JZXJyID0gZ2VuZXJpY19leGVj X3NpbmdsZShjcHUsIGNzZCwgY3NkLT5mdW5jLCBjc2QtPmluZm8sIDApOworCisJLyogV2UgY291 bGQgZGVhZGxvY2sgaWYgd2UgaGF2ZSB0byB3YWl0IGhlcmUgd2l0aCBpbnRlcnJ1cHRzIGRpc2Fi bGVkISAqLworCWlmIChXQVJOX09OX09OQ0UoY3NkLT5mbGFncyAmIENTRF9GTEFHX0xPQ0spKQor CQljc2RfbG9ja193YWl0KGNzZCk7CisKKwljc2QtPmZsYWdzID0gQ1NEX0ZMQUdfTE9DSzsKKwlz bXBfd21iKCk7CisKKwllcnIgPSBnZW5lcmljX2V4ZWNfc2luZ2xlKGNwdSwgY3NkLCBjc2QtPmZ1 bmMsIGNzZC0+aW5mbyk7CiAJcHJlZW1wdF9lbmFibGUoKTsKIAogCXJldHVybiBlcnI7CkBAIC00 MzMsNiArNDQ3LDggQEAgdm9pZCBzbXBfY2FsbF9mdW5jdGlvbl9tYW55KGNvbnN0IHN0cnVjdCBj cHVtYXNrICptYXNrLAogCQlzdHJ1Y3QgY2FsbF9zaW5nbGVfZGF0YSAqY3NkID0gcGVyX2NwdV9w dHIoY2ZkLT5jc2QsIGNwdSk7CiAKIAkJY3NkX2xvY2soY3NkKTsKKwkJaWYgKHdhaXQpCisJCQlj c2QtPmZsYWdzIHw9IENTRF9GTEFHX1NZTkNIUk9OT1VTOwogCQljc2QtPmZ1bmMgPSBmdW5jOwog CQljc2QtPmluZm8gPSBpbmZvOwogCQlsbGlzdF9hZGQoJmNzZC0+bGxpc3QsICZwZXJfY3B1KGNh bGxfc2luZ2xlX3F1ZXVlLCBjcHUpKTsK --001a114100b0d1f0f0050ee63a69--