From: Linus Torvalds <torvalds@linux-foundation.org>
To: Vishwanath Pai <vpai@akamai.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Igor Lubashev <ilubashe@akamai.com>,
Josh Hunt <johunt@akamai.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: xt_hashlimig build error (was Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label)
Date: Thu, 7 Sep 2017 11:43:06 -0700 [thread overview]
Message-ID: <CA+55aFxvD1R0xg8ZEjNyHtvhBZchWBJTU=FQNiY6Mv8E4TqZ=Q@mail.gmail.com> (raw)
In-Reply-To: <69b38985-e094-ddcc-6f7e-d6e5cc2c657e@akamai.com>
On Thu, Sep 7, 2017 at 11:25 AM, Vishwanath Pai <vpai@akamai.com> wrote:
> On 09/07/2017 01:51 PM, Linus Torvalds wrote:
>>
>> But honestly, that math is odd in other ways too (is that "r-1"
>> _supposed_ to underflow to -1 for large 'user' counts?), so somebody
>> needs to look at that logic.
>
> Sorry about the build failure, we have already queued up a fix for this:
> https://patchwork.ozlabs.org/patch/810772/
Note: that patch has *exactly* the issue I was talking about above.
Doing that
if (user > 0xFFFFFFFFULL)
return 0;
is different from the old code, which used to result in a zero in the
divide, and then
r = (r - 1) << 4;
would cause it to return a large value.
So the patch in question doesn't just fix the build error, it
completely changes the semantics of the function too.
I *think* the new behavior is likely what you want, but these kinds of
things should be _described_.
Also, even with the patch, we have garbage:
0xFFFFFFFFULL / (u32)user
why is that sub-expression pointlessly doing a 64-bit divide with a
32-bit number? The compiler is hopefully smart enough to point things
out, but that "ULL" really is _wrong_ there, and could cause a stupid
compiler to still do a 64-bit divide (although hopefully the simpler
version that is 64/32).
So please clarify both the correct behavior _and_ the actual typing of
the divide, ok?
Linus
next prev parent reply other threads:[~2017-09-07 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 17:51 xt_hashlimig build error (was Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label) Linus Torvalds
2017-09-07 18:25 ` Vishwanath Pai
2017-09-07 18:43 ` Linus Torvalds [this message]
2017-09-07 20:16 ` Vishwanath Pai
2017-09-07 20:41 ` Lubashev, Igor
2017-09-07 20:45 ` Linus Torvalds
2017-09-07 21:21 ` Vishwanath Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxvD1R0xg8ZEjNyHtvhBZchWBJTU=FQNiY6Mv8E4TqZ=Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=davem@davemloft.net \
--cc=ilubashe@akamai.com \
--cc=jgross@suse.com \
--cc=johunt@akamai.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=pablo@netfilter.org \
--cc=vpai@akamai.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).