From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964821AbbBBSpo (ORCPT ); Mon, 2 Feb 2015 13:45:44 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:52272 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932141AbbBBSpn (ORCPT ); Mon, 2 Feb 2015 13:45:43 -0500 MIME-Version: 1.0 In-Reply-To: <20150202055429.GH4251@dastard> References: <20150201144058.GM2974@kvack.org> <20150201221458.GN2974@kvack.org> <20150202001628.GO2974@kvack.org> <20150202052944.GF4251@dastard> <20150202055429.GH4251@dastard> Date: Mon, 2 Feb 2015 10:45:42 -0800 X-Google-Sender-Auth: E3Uidw8OAamLdHGmZlXsCh0GmQA Message-ID: Subject: Re: [GIT PULL] aio: fix sleeping while TASK_INTERRUPTIBLE From: Linus Torvalds To: Dave Chinner Cc: linux-aio@kvack.org, Kernel Mailing List , Benjamin LaHaise Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 1, 2015 at 9:54 PM, Dave Chinner wrote: > > Simple enough - the patch below removes the warning from generic/036 > for me. So because this is a debugging thing, I'd actually prefer these "sched_annotate_sleep()" calls to always come with short comments in code why they exist and why they are fine. In this case, it might be as simple as "If the mutex blocks and wakes us up, the loop in wait_event_interruptible_hrtimeout() will just schedule without sleeping and repeat. The ting-lock doesn't block often enough for this to be a performance issue". or perhaps just point to the comment in read_events(). Linus