From: Linus Torvalds <torvalds@linux-foundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH Y.A. RESEND] MAINTAINERS: fix alpha. ordering
Date: Sun, 23 Jul 2017 12:49:08 -0700 [thread overview]
Message-ID: <CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com> (raw)
In-Reply-To: <bc41edea-e303-ee03-de24-c8b2f33ea5d1@infradead.org>
Ok, so I already applied your alpha-ordering patch, but it just annoyed me that
(a) the ordering wasn't complete
(b) this wasn't scripted.
However, the sane way of scripting it is clearly not to do it in C,
which I'd be comfy with, because that would be insane.
Instead, it should be done in perl. Except my perl-fu is so horribly
horribly bad that I'm a bit ashamed to show the end result.
Does anybody have actual real perl skills? Because somebody should
double-check my appended script-from-hell.
ANYWAY. One reason I did this was because *if* we want to split up the
MAINTAINERS file, I absolutely refuse to do it by hand. It needs to be
automated. I'm not going to apply a patch - I'm going to apply a
*script*, and commit the end result along with the doc about what the
script was (so that then I have an inevitable conflict due to this big
re-org, I can resolve the conflict by re-running the script on the
side that wasn't part of the re-org, rather than having to do nasty
things).
And this script could easily be extended to automate the scripting. So
please, can somebody with perl-fu say that "yeah, that's the right
perl model", or point me to what I did wrong?
The end result looks ok. I can run
perl parse-maintainers.pl < MAINTAINERS > outfile
and the end result is actually a *properly* sorted MAINTAINERS file as
far as I can tell.
Comments?
Linus
---
#!/usr/bin/perl -w
use strict;
my %map;
# sort comparison function
sub by_category($$) {
my ($a, $b) = @_;
$a = uc $a;
$b = uc $b;
# This always sorts last
$a =~ s/THE REST/ZZZZZZ/g;
$b =~ s/THE REST/ZZZZZZ/g;
$a cmp $b;
}
sub alpha_output {
my $key;
my $sort_method = \&by_category;
foreach $key (sort $sort_method keys %map) {
if ($key ne " ") {
print $key;
}
print $map{$key};
}
}
sub file_input {
my $lastline = "";
my $case = " ";
$map{$case} = "";
while (<>) {
my $line = $_;
# Pattern line?
if ($line =~ m/^([A-Z]):\s*(.*)/) {
if ($lastline eq "") {
$map{$case} = $map{$case} . $line;
next;
}
$case = $lastline;
$map{$case} = $line;
$lastline = "";
next;
}
$map{$case} = $map{$case} . $lastline;
$lastline = $line;
}
$map{$case} = $map{$case} . $lastline;
}
&file_input;
&alpha_output;
exit(0);
next prev parent reply other threads:[~2017-07-23 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 20:32 [PATCH Y.A. RESEND] MAINTAINERS: fix alpha. ordering Randy Dunlap
2017-07-22 2:01 ` Linus Torvalds
2017-07-23 19:49 ` Linus Torvalds [this message]
2017-07-23 20:00 ` Linus Torvalds
2017-07-23 20:10 ` Joe Perches
2017-07-23 23:14 ` Linus Torvalds
2017-07-24 1:38 ` Joe Perches
2017-07-28 0:30 ` Joe Perches
2017-07-28 2:43 ` Linus Torvalds
2017-07-28 3:12 ` Joe Perches
2017-07-28 22:30 ` Linus Torvalds
2017-07-29 1:08 ` Joe Perches
2017-07-29 17:46 ` Joe Perches
2017-07-23 20:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).