From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753432AbdCPSX7 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 14:23:59 -0400
Received: from mail-it0-f68.google.com ([209.85.214.68]:35238 "EHLO
        mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753353AbdCPSXs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 14:23:48 -0400
MIME-Version: 1.0
In-Reply-To: <CAP045ArvvVVNOLDzMp=B_1AMsRBb9n2qkChkdB7gaEscTOh4Xg@mail.gmail.com>
References: <20170311194702.28754-1-khuey@kylehuey.com> <20170311194702.28754-7-khuey@kylehuey.com>
 <CA+55aFxGYA_MnVnmtqfX+AW3hE-KE9Bvev65urRKCA7BgmRiOA@mail.gmail.com>
 <87shmdjx4u.fsf@concordia.ellerman.id.au> <CAP045ArvvVVNOLDzMp=B_1AMsRBb9n2qkChkdB7gaEscTOh4Xg@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 16 Mar 2017 11:23:41 -0700
X-Google-Sender-Auth: IpPcrAqYcmDL3mXS9u6PTsMrmwg
Message-ID: <CA+55aFy=i=er6kgW+y+Ai2fxfNX2N61ZfwJeKDOr-1On90HXug@mail.gmail.com>
Subject: Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID
To: Kyle Huey <me@kylehuey.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
        "Robert O'Callahan" <robert@ocallahan.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Shuah Khan <shuah@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Len Brown <len.brown@intel.com>,
        Dmitry Safonov <dsafonov@virtuozzo.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        David Matlack <dmatlack@google.com>, Nadav Amit <nadav.amit@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
        "open list:USER-MODE LINUX (UML)" 
        <user-mode-linux-user@lists.sourceforge.net>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KVM list <kvm@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 16, 2017 at 7:30 AM, Kyle Huey <me@kylehuey.com> wrote:
> On Thu, Mar 16, 2017 at 4:09 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Presumably he's done:
>>
>> $ git config diff.context 8
>
> Indeed.  In my case it dates back to my days hacking on Firefox, which
> wants 8 lines of context for patches.  I'll remove it.

You can make those kinds of options per-repository rather than
user-global, so you can keep the 8-line thing for firefox without
having it for the kernel.

Not that it *hurts* for the kernel, but it just looked odd to me
because the patch looked so much bigger. More context lines can
obviously help with ambiguous cases, but we very seldom have that kind
of ambiguity.

I'm assuming firefox has files that have lots and lots of repeated
lines (or things like autogenerated content with a lot of common
boilerplate or whatever), which is why they like lots of context?

                     Linus