From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751411AbcCKScq (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Mar 2016 13:32:46 -0500
Received: from mail-io0-f176.google.com ([209.85.223.176]:35024 "EHLO
	mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750708AbcCKSco (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Mar 2016 13:32:44 -0500
MIME-Version: 1.0
In-Reply-To: <20160311113206.GD4312@pd.tnic>
References: <20160310111935.GB13102@gmail.com>
	<CAHp75Vetx62afSZXLT96C02s=eXLZSap5poYnMUsMEZ=UfcFqw@mail.gmail.com>
	<20160310125610.GA26708@pd.tnic>
	<CAHp75Vep=e3HWHHJh-Z6Q9yr8dik715ctbthABxf2Grbuf7jow@mail.gmail.com>
	<20160310145940.GB26708@pd.tnic>
	<CALCETrW5_GfXYCgocmESHf3G-2RWmhmc-+81fX0eDxFH5vu3VQ@mail.gmail.com>
	<20160311090840.GA8486@gmail.com>
	<20160311094802.GA4312@pd.tnic>
	<1457694124.2007.12.camel@nexus-software.ie>
	<20160311112610.GC4312@pd.tnic>
	<20160311113206.GD4312@pd.tnic>
Date: Fri, 11 Mar 2016 10:32:43 -0800
X-Google-Sender-Auth: E3iuvDFzXbRX1wu2gXJycAqa7pE
Message-ID: <CA+55aFyHQ0+zM5pBNWakA_ti4gutLX5VdounyuduGeFGTmvksg@mail.gmail.com>
Subject: Re: [PATCH] x86/FPU: Fix FPU handling on legacy FPU machines
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>,
        "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        Andy Lutomirski <luto@amacapital.net>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>, Fenghua Yu <fenghua.yu@intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Oleg Nesterov <oleg@redhat.com>,
        "Yu, Yu-cheng" <yu-cheng.yu@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 11, 2016 at 3:32 AM, Borislav Petkov <bp@alien8.de> wrote:
> 486 cores like Intel Quark support only the very old, legacy x87 FPU
> (FSAVE/FRSTOR, CPUID bit FXSR is not set). And our FPU code wasn't
> handling the saving and restoring there properly. First, Andy Shevchenko
> reported a splat:
>
>   WARNING: CPU: 0 PID: 823 at arch/x86/include/asm/fpu/internal.h:163 fpu__clear+0x8c/0x160
>
> which was us trying to execute FXRSTOR on those machines even though
> they don't support it.
>
> After taking care of that, Bryan O'Donoghue reported that a simple FPU
> test still failed because we weren't initializing the FPU state properly
> on those machines.

Obvious Ack to the patch, along with a "how did this ever work
before?" comment..

           Linus