From: Linus Torvalds <torvalds@linux-foundation.org>
To: Paul Moore <pmoore@redhat.com>
Cc: linux-audit@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: Audit fixes for v4.11 (#1)
Date: Sat, 25 Mar 2017 15:23:35 -0700 [thread overview]
Message-ID: <CA+55aFyLuR8rxSjps-FF=aMaUpy4gGQpNxLAgDqSbVm7fqdaVA@mail.gmail.com> (raw)
In-Reply-To: <CAGH-KgsSh73q8pTymj2QH_zFxJdvioZGj9+oTn6a5=Ueo0Z4BA@mail.gmail.com>
On Fri, Mar 24, 2017 at 2:39 PM, Paul Moore <pmoore@redhat.com> wrote:
>
> This code has passed our testsuite without problem and it has held up
> to my ad-hoc stress tests (arguably better than the existing code),
> please consider pulling this as fix for the next v4.11-rcX tag.
Ok, pulled. However, looking at the changes in the patch it becomes
obvious that it is now completely bogus to inline the
"audit_signal_info()" function.
That silly inline in the header file now only generates bigger and
slower code, since that inlined function now calls another function
auditd_test_task() that is *not* inlined, so it ends up being a
function call anyway.
It would be much better to just unlinline audit_signal_info(), move it
into kernel/audit.c, and let the compiler then inline the
__audit_signal_info() helper function (or just fold it into that
function manually as part of the move).
The whole reason for that inlined part, and the uninlined
__audit_signal_info() helper was that the code *used* to be able to
avoid a function call entirely. That reason is now gone.
Linus
next prev parent reply other threads:[~2017-03-25 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 21:39 Audit fixes for v4.11 (#1) Paul Moore
2017-03-25 14:49 ` [GIT PULL] " Paul Moore
2017-03-25 22:23 ` Linus Torvalds [this message]
2017-03-26 15:18 ` Paul Moore
2017-03-26 17:23 ` Linus Torvalds
2017-03-27 19:05 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyLuR8rxSjps-FF=aMaUpy4gGQpNxLAgDqSbVm7fqdaVA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmoore@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).