From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
George Spelvin <linux@horizon.com>,
Scott Bauer <sbauer@eng.utah.edu>,
Andi Kleen <ak@linux.intel.com>,
Andy Lutomirski <luto@amacapital.net>,
Greg KH <gregkh@linuxfoundation.org>,
Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com>,
"Daniel J . Bernstein" <djb@cr.yp.to>
Subject: Re: [PATCH v3] siphash: add cryptographically secure hashtable function
Date: Tue, 13 Dec 2016 11:26:44 -0800 [thread overview]
Message-ID: <CA+55aFyOD4EhD1v7JNTHxvGSqMi7UKgybWH+PZE1KjXeZTT8BA@mail.gmail.com> (raw)
In-Reply-To: <20161213083948.GA8994@zzz>
On Tue, Dec 13, 2016 at 12:39 AM, Eric Biggers <ebiggers3@gmail.com> wrote:
>
> Hmm, I don't think you can really do load_unaligned_zeropad() without first
> checking for 'left != 0'.
Right you are. If the allocation is at the end of a page, the 0-size
case would be entirely outside the page and there's no fixup.
Of course, that never happens in normal code, but DEBUG_PAGE_ALLOC can
trigger it.
Linus
next prev parent reply other threads:[~2016-12-13 19:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 18:36 [PATCH] siphash: add cryptographically secure hashtable function Jason A. Donenfeld
2016-12-10 12:37 ` [kernel-hardening] " Greg KH
2016-12-11 15:30 ` Jason A. Donenfeld
2016-12-11 20:43 ` Greg KH
2016-12-12 3:48 ` [PATCH v2] " Jason A. Donenfeld
2016-12-12 4:01 ` Linus Torvalds
2016-12-12 5:48 ` Jason A. Donenfeld
2016-12-12 21:37 ` Linus Torvalds
2016-12-12 22:18 ` [PATCH v3] " Jason A. Donenfeld
2016-12-12 23:01 ` Andi Kleen
2016-12-13 8:39 ` Eric Biggers
2016-12-13 19:26 ` Linus Torvalds [this message]
2016-12-13 22:43 ` Jason A. Donenfeld
2016-12-13 22:48 ` [PATCH v4] " Jason A. Donenfeld
2016-12-12 5:42 ` [PATCH v2] " Eric Biggers
2016-12-12 21:17 ` Jason A. Donenfeld
2016-12-10 14:17 ` [PATCH] " Vegard Nossum
2016-12-10 15:35 ` George Spelvin
2016-12-12 23:04 [PATCH v3] " Jason A. Donenfeld
2016-12-13 19:25 ` Linus Torvalds
2016-12-13 23:36 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFyOD4EhD1v7JNTHxvGSqMi7UKgybWH+PZE1KjXeZTT8BA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=Jason@zx2c4.com \
--cc=ak@linux.intel.com \
--cc=djb@cr.yp.to \
--cc=ebiggers3@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeanphilippe.aumasson@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=luto@amacapital.net \
--cc=sbauer@eng.utah.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).