From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758760AbcLUTpI (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Dec 2016 14:45:08 -0500
Received: from mail-io0-f196.google.com ([209.85.223.196]:36413 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756199AbcLUTpG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Dec 2016 14:45:06 -0500
MIME-Version: 1.0
In-Reply-To: <20161221143605.2272-3-sergey.senozhatsky@gmail.com>
References: <20161221143605.2272-1-sergey.senozhatsky@gmail.com> <20161221143605.2272-3-sergey.senozhatsky@gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 21 Dec 2016 11:45:05 -0800
X-Google-Sender-Auth: _hQl7cTY3xAVaGJMgnR4z2LfC4U
Message-ID: <CA+55aFyU-XvPqiPAFjetK6Sn8GUqnX0zjLKu=fd317Cxz4KwSw@mail.gmail.com>
Subject: Re: [PATCHv6 2/7] printk: rename nmi.c and exported api
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>, Jan Kara <jack@suse.cz>,
        Tejun Heo <tj@kernel.org>, Calvin Owens <calvinowens@fb.com>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 21, 2016 at 6:36 AM, Sergey Senozhatsky
<sergey.senozhatsky@gmail.com> wrote:
> A preparation patch for printk_safe work. No functional change.
> - rename nmi.c to print_safe.c
> - rename exported functions to have a `printk_safe' prefix.

I dislike this patch.

It's _mostly_ ok, but the nmi naming is nasty.

Either "printk_nmi()" or "printk_safe" is fine, but doing *both* is
stupid and wrong. And you do both in a couple of places.

So please keep the printk_nmi_enter/exit() naming. Because
"printk_safe_nmi_enter/exit()" is just stupid.  It's about nmi entry.
The "safe" part is simply an implementation detail.

                Linus