From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752483AbdGDQSq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Jul 2017 12:18:46 -0400
Received: from mail-oi0-f42.google.com ([209.85.218.42]:34325 "EHLO
        mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752430AbdGDQSo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Jul 2017 12:18:44 -0400
MIME-Version: 1.0
In-Reply-To: <20170704113611.GA4732@decadent.org.uk>
References: <20170619142358.GA32654@1wt.eu> <1498009101.2655.6.camel@decadent.org.uk>
 <20170621092419.GA22051@dhcp22.suse.cz> <1498042057.2655.8.camel@decadent.org.uk>
 <1499126133.2707.20.camel@decadent.org.uk> <CA+55aFzMX72+Kb=zNgjCf6UfPt+C+e7WDp_rpbSLuOVx1k7iqg@mail.gmail.com>
 <20170704084122.GC14722@dhcp22.suse.cz> <20170704093538.GF14722@dhcp22.suse.cz>
 <20170704094728.GB22013@1wt.eu> <20170704104211.GG14722@dhcp22.suse.cz> <20170704113611.GA4732@decadent.org.uk>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 4 Jul 2017 09:18:42 -0700
X-Google-Sender-Auth: S7om_ZWDgOdtTsyAyxxhZFG7kC4
Message-ID: <CA+55aFyY_Nk8Kxm0oJy4+6DY0KnJw2eZUBonb6mEwM0sYDpUew@mail.gmail.com>
Subject: Re: [PATCH] mm: larger stack guard gap, between vmas
To: Ben Hutchings <ben@decadent.org.uk>,
        John Haxby <john.haxby@oracle.com>
Cc: Michal Hocko <mhocko@kernel.org>, Willy Tarreau <w@1wt.eu>,
        Hugh Dickins <hughd@google.com>, Oleg Nesterov <oleg@redhat.com>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>, Rik van Riel <riel@redhat.com>,
        Larry Woodman <lwoodman@redhat.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Tony Luck <tony.luck@intel.com>,
        "James E.J. Bottomley" <jejb@parisc-linux.org>,
        Helge Diller <deller@gmx.de>, James Hogan <james.hogan@imgtec.com>,
        Laura Abbott <labbott@redhat.com>, Greg KH <greg@kroah.com>,
        "security@kernel.org" <security@kernel.org>,
        linux-distros@vs.openwall.org,
        Qualys Security Advisory <qsa@qualys.com>,
        LKML <linux-kernel@vger.kernel.org>, Ximin Luo <infinity0@debian.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 4, 2017 at 4:36 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
>
> That's what I was thinking of.  Tried the following patch:
>
> Subject: mmap: Ignore VM_NONE mappings when checking for space to
>  expand the stack

This looks sane to me.

I'm going to ignore it in this thread, and assume that it gets sent as
a patch separately, ok?

It would be good to have more acks on it.

Also, separately, John Haxby kind of implied that the LibreOffice
regression on i386 is already fixed by commit f4cb767d76cf ("mm: fix
new crash in unmapped_area_topdown()").

Or was that a separate issue?

               Linus