From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbdK2VFm (ORCPT ); Wed, 29 Nov 2017 16:05:42 -0500 Received: from mail-it0-f43.google.com ([209.85.214.43]:45442 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752691AbdK2VFk (ORCPT ); Wed, 29 Nov 2017 16:05:40 -0500 X-Google-Smtp-Source: AGs4zMafqZVILShNds0GiRPUA7oK/yyAtwDYDVsq2+7L4adaXAat6XZTaaAQ1vXraYUcRhtJsxb6PYwD2kxW/annjiM= MIME-Version: 1.0 In-Reply-To: <1511988840.19952.76.camel@perches.com> References: <20171129045927.GA6217@eros> <1511988840.19952.76.camel@perches.com> From: Linus Torvalds Date: Wed, 29 Nov 2017 13:05:39 -0800 X-Google-Sender-Auth: T-NsVFdS6YmOE4okg8pgZ2skVnQ Message-ID: Subject: Re: [GIT PULL] hash addresses printed with %p To: Joe Perches Cc: "Tobin C. Harding" , Kees Cook , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 12:54 PM, Joe Perches wrote: > > I'd prefer a global sed of '%pK' to '%pxK' and remove '%pK' altogether No, we really don't want %pK to become %pxK. Most of the %pK users absolutely do not want the real hex address. They are things like the socket pointers in /proc etc. The exact thing that the hashing does well, and that %pK was so useless for. Anyway, with the current tree, the "leaking_addresses script gives almost no results for me (and I have kptr_restrict set to 0). I haven't seen any breakage, but I may change my mind if bug reports end up being illegible. And maybe I just haven't triggered anything that might use a pointer. Annotated perf disassembly is broken for me right now, but that happens to me with alarming regularity because perf uses the wrong vmlinux file or something, so it is probably not related (the kernel symbol show up properly in the profile, I just don't get the disassembly). Linus