From: Linus Torvalds <torvalds@linux-foundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Steven Rostedt <rostedt@goodmis.org>,
David Rientjes <rientjes@google.com>,
Douglas Anderson <dianders@chromium.org>,
Guenter Roeck <linux@roeck-us.net>,
Mark Brown <broonie@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [RFC] clang: 'unused-function' warning on static inline functions
Date: Tue, 6 Jun 2017 09:32:35 -0700 [thread overview]
Message-ID: <CA+55aFyhgWGr-=9t7131XAUyNy8Zs_vUfp-PGu_eaLkMAa6=sg@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3nrxvTVx8zjgf+_byAX82FG8jFD73L2nPSJBwK5grdXA@mail.gmail.com>
On Tue, Jun 6, 2017 at 4:16 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> Those should all be fairly easy to address, I'd vote for leaving the
> warning enabled
> in clang, and possibly asking the gcc maintainers to add a similar feature for
> warning about it.
Hell no. That warning is pointless shit.
The function is inlined. If it's not used, why the f*ck should you get
a warning? Just to add more pointless #ifdef'fery around a function
that is perhaps only used under certain circumstances?
No. That warning is garbage, and we will ignore it, and we sure as
hell will not ask gcc to add more garbage warnings.
Linus
next prev parent reply other threads:[~2017-06-06 16:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 18:13 [RFC] clang: 'unused-function' warning on static inline functions Matthias Kaehlcke
2017-05-31 23:55 ` Matthias Kaehlcke
2017-06-06 11:16 ` Arnd Bergmann
2017-06-06 16:32 ` Linus Torvalds [this message]
2017-06-06 21:23 ` Matthias Kaehlcke
2017-06-06 21:28 ` Linus Torvalds
2017-06-07 0:28 ` Matthias Kaehlcke
2017-06-07 5:59 ` David Rientjes
2017-06-07 19:43 ` Arnd Bergmann
2017-06-07 20:36 ` Linus Torvalds
2017-06-07 21:24 ` Steven Rostedt
2017-06-08 8:59 ` Arnd Bergmann
2017-06-06 21:29 ` Jens Axboe
2017-06-07 8:17 ` Arnd Bergmann
2017-06-07 12:58 ` Steven Rostedt
2017-06-07 13:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyhgWGr-=9t7131XAUyNy8Zs_vUfp-PGu_eaLkMAa6=sg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).