From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933499AbcIFUDp (ORCPT ); Tue, 6 Sep 2016 16:03:45 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33639 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932651AbcIFUDo (ORCPT ); Tue, 6 Sep 2016 16:03:44 -0400 MIME-Version: 1.0 In-Reply-To: <20160906194443.GC1041@n2100.armlinux.org.uk> References: <20160906140808.2883875-1-arnd@arndb.de> <20160906142442.GY1041@n2100.armlinux.org.uk> <6239709.hYdxF7WW9G@wuerfel> <20160906194443.GC1041@n2100.armlinux.org.uk> From: Linus Torvalds Date: Tue, 6 Sep 2016 13:03:42 -0700 X-Google-Sender-Auth: yQcUwTsOxrz8uSnZySN0OEY1l4M Message-ID: Subject: Re: [PATCH] ARM: mmp: replace NO_IRQ To: Russell King - ARM Linux Cc: Arnd Bergmann , Eric Miao , Haojian Zhuang , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 6, 2016 at 12:44 PM, Russell King - ARM Linux wrote: > > My point still stands though. Merely hiding it doesn't make the problem > go away - it's just the same problem but now it won't be as visible, and > as such it'll probably never get resolved. How much of a legacy thing is this? The main reason I'd like to _really_ make NO_IRQ go away is that it seems that some people copy it from existing drivers, or just think it's the RightThing(tm) to do because it looks so plausible. So in that sense I wouldn't actually mind "merely hiding it". It may not *fix* that particular driver or subsystem, but if it's sufficiently well hidden or specialized, at least it won't cause the pattern to be copied in the future, I'd hope. So hiding things inside a particular driver (or a particular subsystem) may be hacky from the standpoint of that particular driver or subsystem, but from a "big issue" standpoint I don't mind at all. Linus