From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-mm <linux-mm@kvack.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Ingo Molnar" <mingo@kernel.org>,
"Michel Lespinasse" <walken@google.com>,
"Hugh Dickins" <hughd@google.com>, "Jörn Engel" <joern@logfs.org>
Subject: Re: [PATCH v2] mm: Downgrade mmap_sem before locking or populating on mmap
Date: Sun, 16 Dec 2012 11:58:09 -0800 [thread overview]
Message-ID: <CA+55aFyzjvq=qQM1sNcyqt06u_05zyYv4RyCx+n8vZ4RLu7R5g@mail.gmail.com> (raw)
In-Reply-To: <2e91ea19fbd30fa17718cb293473ae207ee8fd0f.1355536006.git.luto@amacapital.net>
On Fri, Dec 14, 2012 at 6:17 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> This is a serious cause of mmap_sem contention. MAP_POPULATE
> and MCL_FUTURE, in particular, are disastrous in multithreaded programs.
>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Ugh. This patch is just too ugly.
Conditional locking like this is just too disgusting for words. And
this v2 is worse, with that whole disgusting 'downgraded' pointer
thing.
I'm not applying disgusting hacks like this. I suspect you can clean
it up by moving the mlock/populate logic into the (few) callers
instead (first as a separate patch that doesn't do the downgrading)
and then a separate patch that does the downgrade in the callers,
possibly using a "finish_mmap" helper function that releases the lock.
No "if (write) up_write() else up_read()" crap. Instead, make the
finish_mmap helper do something like
if (!populate_r_mlock) {
up_write(mmap_sem);
return;
}
downgrade(mmap_sem);
.. populate and mlock ..
up_read(mmap_sem);
and you never have any odd "now I'm holding it for writing" state
variable with conditional locking rules etc.
Linus
prev parent reply other threads:[~2012-12-16 19:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 5:49 [PATCH] mm: Downgrade mmap_sem before locking or populating on mmap Andy Lutomirski
2012-12-14 7:27 ` Al Viro
2012-12-14 11:14 ` Andy Lutomirski
2012-12-14 14:49 ` Al Viro
2012-12-14 16:12 ` Andy Lutomirski
2012-12-16 8:41 ` Ingo Molnar
2012-12-16 17:04 ` Al Viro
2012-12-16 17:48 ` Al Viro
2012-12-16 18:49 ` Johannes Weiner
2012-12-16 19:53 ` Al Viro
2012-12-16 20:16 ` Al Viro
2012-12-15 2:17 ` [PATCH v2] " Andy Lutomirski
2012-12-16 9:00 ` Ingo Molnar
2012-12-16 17:52 ` Andy Lutomirski
2012-12-17 9:52 ` Ingo Molnar
2012-12-18 0:54 ` [PATCH v3] " Andy Lutomirski
2012-12-20 2:22 ` Simon Jeons
2012-12-16 12:39 ` [PATCH v2] " Michel Lespinasse
2012-12-16 18:05 ` Andy Lutomirski
2012-12-17 3:29 ` Michel Lespinasse
2012-12-17 22:01 ` Andy Lutomirski
2012-12-16 19:58 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyzjvq=qQM1sNcyqt06u_05zyYv4RyCx+n8vZ4RLu7R5g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).