From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751423AbbHAQjL (ORCPT <rfc822;w@1wt.eu>);
	Sat, 1 Aug 2015 12:39:11 -0400
Received: from mail-ig0-f172.google.com ([209.85.213.172]:37992 "EHLO
	mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751120AbbHAQjI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 1 Aug 2015 12:39:08 -0400
MIME-Version: 1.0
In-Reply-To: <20150801163311.GA15356@nazgul.tnic>
References: <1431714237-880-6-git-send-email-toshi.kani@hp.com>
	<1432628901-18044-6-git-send-email-bp@alien8.de>
	<tip-0cc705f56e400764a171055f727d28a48260bb4b@git.kernel.org>
	<20150731131802.GW25159@twins.programming.kicks-ass.net>
	<20150731144452.GA8106@nazgul.tnic>
	<20150731150806.GX25159@twins.programming.kicks-ass.net>
	<20150731152713.GA9756@nazgul.tnic>
	<20150801142820.GU30479@wotan.suse.de>
	<20150801163311.GA15356@nazgul.tnic>
Date: Sat, 1 Aug 2015 09:39:07 -0700
X-Google-Sender-Auth: lv8WZ8X7KOkVJ_IBi7oxJs2M_h0
Message-ID: <CA+55aFzBvRYLufS46QR2aXLYX=rMBQ-qKjkkhQm-L9dFgwWywA@mail.gmail.com>
Subject: Re: [tip:x86/mm] x86/mm/mtrr: Clean up mtrr_type_lookup()
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Luis R. Rodriguez" <mcgrof@suse.com>, Toshi Kani <toshi.kani@hp.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Anvin <hpa@zytor.com>, Denys Vlasenko <dvlasenk@redhat.com>,
        Borislav Petkov <bp@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brian Gerst <brgerst@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
        linux-mm <linux-mm@kvack.org>, Andy Lutomirski <luto@amacapital.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Aug 1, 2015 at 9:33 AM, Borislav Petkov <bp@alien8.de> wrote:
>
> Well, it doesn't really make sense to write-combine IO memory, does it?

Quite the reverse.

It makes no sense to write-combine normal memory (RAM), because caches
work and sane memory is always cache-coherent. So marking regular
memory write-combining is a sign of crap hardware (which admittedly
exists all too much, but hopefully goes away).

In contrast, marking MMIO memory write-combining is not a sign of crap
hardware - it's just a sign of things like frame buffers on the card
etc. Which very much wants write combining. So WC for MMIO at least
makes sense.

Yes, yes, I realize that "crap hardware" may actually be the more
common case, but still..

             Linus