From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752176AbbHSWdw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 19 Aug 2015 18:33:52 -0400
Received: from mail-ig0-f176.google.com ([209.85.213.176]:33887 "EHLO
	mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751165AbbHSWdv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 19 Aug 2015 18:33:51 -0400
MIME-Version: 1.0
In-Reply-To: <55D453B0.2090108@zytor.com>
References: <20150814071500.GA2678@gmail.com>
	<CA+55aFwP6gJ5Qh7btvf_gME35nvR-se==MuRcvctDqdxEQ9SJA@mail.gmail.com>
	<20150817080143.GA16928@gmail.com>
	<CA+55aFw4pjStVG6zqqS7VCeWvqH+mKcGV_CwqqyRbB1NGcZqug@mail.gmail.com>
	<F96A2BC9-B57F-4360-9DF2-A252BB9462B7@zytor.com>
	<CA+55aFwjbXFKE0u0stUV1s0E-3MrQ4HAcXMCPiaOjqZps5wWJQ@mail.gmail.com>
	<55D25D7F.40503@zytor.com>
	<20150819055931.GD32338@gmail.com>
	<20150819065056.GB28292@gmail.com>
	<55D453B0.2090108@zytor.com>
Date: Wed, 19 Aug 2015 15:33:50 -0700
X-Google-Sender-Auth: xGT6k90yhy5wQvmZDdBryd9oyBI
Message-ID: <CA+55aFzmJGMDouT_5S3OhANeN5Es8ORLeTrCVdMgLjfUgihXKw@mail.gmail.com>
Subject: Re: [GIT PULL] x86 fixes
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@kernel.org>, Juergen Gross <jgross@suse.com>,
        Andy Lutomirski <luto@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Brian Gerst <brgerst@gmail.com>, Denys Vlasenko <dvlasenk@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 19, 2015 at 3:00 AM, H. Peter Anvin <hpa@zytor.com> wrote:
>
> And I bet if CPUID actually reported the right thing it probably would work
> okay.  As I said, I tested this under Qemu which reported an accurate (lack
> of) CPUID for a 486SX.

While I agree that cpuid is a problem for FPU emulation on modern
CPU's, if this is due to "fucomip" then I think it's just that modern
distributions (and not-so-modern ones, for that matter) are compiled
with i686 support, so gcc just generates fucomip directly. So it's
just "plain FPU" code (no mmx, nothing like that), but it still fails.

The "set regular integer flags instructions" versions of floating
point compares are some of the bigger improvements to the legacy i87
instruction set, because the sequences to do FP compares without them
are just insane. I forget the details, but it's something like "store
status word to ax, then use sahf to get it into the flags register".
Crazy crazy crap. So it's no wonder that gcc wants to use a i686-only
instruction even for just regular FP code if at all possible.

I suspect it shouldn't be that hard to add f[u]compi[p] support to the
emulator.

But I also expect that most modern distributions are likely fairly
eager to use mmx etc, which sounds like a major pain to emulate.

                Linus