From: Linus Torvalds <torvalds@linux-foundation.org> To: Steven Rostedt <rostedt@goodmis.org> Cc: Kees Cook <keescook@chromium.org>, Anna-Maria Gleixner <anna-maria@linutronix.de>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, tcharding <me@tobin.cc> Subject: Re: Hashed pointer issues Date: Mon, 30 Apr 2018 16:57:36 +0000 Message-ID: <CA+55aFzpJC4+tuSopeze72D2sv1urGdap8+Bj2Y9hEYitAkE4Q@mail.gmail.com> (raw) In-Reply-To: <20180430124135.0cce92e3@gandalf.local.home> On Mon, Apr 30, 2018 at 9:41 AM Steven Rostedt <rostedt@goodmis.org> wrote: > > > > And if we really want a command line option, can we make that still hash > > the pointer, just force the entropy early. That way kernel developers that > > test that command line option are still testing the *hashing*, they just > > are missing the good entropy. > That may work too. Even with bad entropy, pointers at start up are hard > to come by, and I can't see a hacker being able to use them as it only > happens once during boot. No, if people use the command line option, *all* pointers - not just the boot-time ones - would get cryptographically bad hashes, since you don't want to change the hash once it's picked (because then you couldn't use the hashing to identify objects). So the boot command line wouldn't affect just the bootup hashing, it would be bad at runtime too. But at least a person booting with that option would get the same *behavior* as everybody else, and they wouldn't be testing something fundamnetally different (it's still hashing, just not cryptographically strong). Although in *practice* we'd have tons of entropy on any modern development CPU too, since any new hardware will have the hardware random number generation. Some overly cautious person might not trust it, of course. Linus
next prev parent reply index Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-30 15:50 Anna-Maria Gleixner 2018-04-30 16:11 ` Kees Cook 2018-04-30 16:31 ` Linus Torvalds 2018-04-30 16:41 ` Steven Rostedt 2018-04-30 16:57 ` Linus Torvalds [this message] 2018-04-30 17:01 ` Linus Torvalds 2018-04-30 17:06 ` Randy Dunlap 2018-04-30 17:12 ` Linus Torvalds 2018-05-01 7:05 ` tcharding 2018-05-03 8:41 ` Geert Uytterhoeven 2018-04-30 18:38 ` Kees Cook 2018-04-30 19:00 ` Linus Torvalds 2018-04-30 19:16 ` Kees Cook 2018-04-30 20:01 ` Linus Torvalds 2018-04-30 20:07 ` Linus Torvalds 2018-04-30 21:23 ` Tobin C. Harding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+55aFzpJC4+tuSopeze72D2sv1urGdap8+Bj2Y9hEYitAkE4Q@mail.gmail.com \ --to=torvalds@linux-foundation.org \ --cc=anna-maria@linutronix.de \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=me@tobin.cc \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git