From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756241Ab2APTZf (ORCPT ); Mon, 16 Jan 2012 14:25:35 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:61590 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755950Ab2APTZc (ORCPT ); Mon, 16 Jan 2012 14:25:32 -0500 MIME-Version: 1.0 In-Reply-To: <1326691403.13517.21.camel@minggr> References: <20120109003255.GA6598@havoc.gtf.org> <4F12E57E.3090805@garzik.org> <1326676534.13517.3.camel@minggr> <1326691403.13517.21.camel@minggr> From: Linus Torvalds Date: Mon, 16 Jan 2012 11:25:09 -0800 X-Google-Sender-Auth: A3s-ZJGnT7hPyyH7hD5QT8WHzig Message-ID: Subject: Re: [git patches] libata updates for 3.3 To: Lin Ming Cc: Jeff Garzik , Andrew Morton , linux-ide@vger.kernel.org, LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2012 at 9:23 PM, Lin Ming wrote: > > Set SATA mode to IDE on my machine can reproduce this problem. > The cause is that ata port async suspend was not enabled yet. Yup. Your patch helps. But why don't we fix the silly legacy mode thing? Yeah, Apple's firmware is crap and doesn't tend to initialize things, but still - we should have at least an option to not use the legacy PIIX mode just because the chipset wasn't programmed for AHCI by the bootup. That would also help with people who have a BIOS that has the option, but where the person hadn't noticed, and left it in legacy mode. The IO ports are all there, the *only* reason we don't use AHCI seems to be that the firmware didn't turn off the legacy bit, so it doesn't show as an AHCI interface. That's kind of sad. Linus