From: Josh Boyer <jwboyer@fedoraproject.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Zoltan Kiss <zoltan.kiss@citrix.com>,
Luis Henriques <luis.henriques@canonical.com>,
David Miller <davem@davemloft.net>,
jesse@nicira.com, pshelar@nicira.com,
Thomas Graf <tgraf@redhat.com>,
dev@openvswitch.org, pablo@netfilter.org,
kadlec@blackhole.kfki.hu, edumazet@google.com,
Daniel Borkmann <dborkman@redhat.com>,
Tom Herbert <therbert@google.com>,
jasowang@redhat.com, fw@strlen.de, Joe Perches <joe@perches.com>,
horms@verge.net.au, jiri@resnulli.us, mst@redhat.com,
Paul.Durrant@citrix.com, Jan Beulich <JBeulich@suse.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
mszeredi@suse.cz, netfilter-devel@vger.kernel.org,
netfilter@vger.kernel.org, xen-devel@lists.xenproject.org,
netdev <netdev@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 3.13] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Wed, 23 Apr 2014 09:31:25 -0400 [thread overview]
Message-ID: <CA+5PVA4pPG9yVO1C1JnkxV3mSdAqh3QB44Y8xsVRvQv5PHM-Ag@mail.gmail.com> (raw)
In-Reply-To: <1398194284.7767.101.camel@deadeye.wl.decadent.org.uk>
On Tue, Apr 22, 2014 at 3:18 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> From: Zoltan Kiss <zoltan.kiss@citrix.com>
>
> commit 36d5fe6a000790f56039afe26834265db0a3ad4c upstream.
>
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well, and modify the callers accordingly. skb_tx_error() is also added to
> the callers so they will signal the failed delivery towards the creator of the
> skb.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> [bwh: Backported to 3.13: skb_zerocopy() is new in 3.14, but was moved from a
> static function in nfnetlink_queue. We need to patch that and its caller, but
> not openvswitch.]
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Deja-vu. I sent almost the same patch to netdev a while ago and you
acked it there. So I guess I'll ack your copy as well :). Not sure
why either version wasn't picked up by Dave.
josh
prev parent reply other threads:[~2014-04-23 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 22:37 [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Zoltan Kiss
2014-03-27 19:29 ` David Miller
2014-04-21 11:26 ` Luis Henriques
2014-04-22 15:38 ` Ben Hutchings
2014-04-22 18:02 ` Zoltan Kiss
2014-04-22 19:18 ` [PATCH 3.13] " Ben Hutchings
2014-04-23 8:57 ` Luis Henriques
2014-04-23 12:34 ` Zoltan Kiss
2014-04-23 13:31 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+5PVA4pPG9yVO1C1JnkxV3mSdAqh3QB44Y8xsVRvQv5PHM-Ag@mail.gmail.com \
--to=jwboyer@fedoraproject.org \
--cc=JBeulich@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=jasowang@redhat.com \
--cc=jesse@nicira.com \
--cc=jiri@resnulli.us \
--cc=joe@perches.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
--cc=mst@redhat.com \
--cc=mszeredi@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pshelar@nicira.com \
--cc=tgraf@redhat.com \
--cc=therbert@google.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).