From: Josh Boyer <jwboyer@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: acme@ghostprotocols.net, mingo@kernel.org, tglx@linutronix.de,
bp@alien8.de, namhyung@gmail.com, torvalds@linux-foundation.org,
paulus@samba.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [GIT PULL] UAPI: perf fixes
Date: Mon, 12 Nov 2012 15:23:51 -0500 [thread overview]
Message-ID: <CA+5PVA5vMyNmQYCLX315Jc+kN9zQuZo_h0Devpjfr43TezE-qA@mail.gmail.com> (raw)
In-Reply-To: <1378.1352379110@warthog.procyon.org.uk>
On Thu, Nov 8, 2012 at 7:51 AM, David Howells <dhowells@redhat.com> wrote:
>
> (6) Make perf work for x86 by adding -I flags and changing long #includes
> with "../../include" in them into short <asm/foo.h> type things.
This patch seems to break building perf on ppc64. It fails with:
+ make -j16 -C tools/perf -s V=1 WERROR=0 HAVE_CPLUS_DEMANGLE=1 prefix=/usr all
<snip>
builtin-kvm.c:25:21: fatal error: asm/svm.h: No such file or directory
compilation terminated.
make: *** [builtin-kvm.o] Error 1
make: *** Waiting for unfinished jobs....
And that is indeed because arch/powerpc/include/asm/svm.h doesn't exist
(and therefore can't be exported like the first patch for x86 in this
series does). You can find full build logs with this patch series
applied here: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=781782
However, without some form of fix for the ../.. includes, perf still
fails to build on arches like ARM and powerpc with errors like this:
In file included from util/../perf.h:29:0,
from util/cache.h:7,
from util/quote.c:1:
util/../../../arch/powerpc/include/asm/unistd.h:12:29: fatal error:
uapi/asm/unistd.h: No such file or directory
compilation terminated.
make: *** [util/parse-events-test.o] Error 1
Full build logs here:
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=781076
So. Something else might need to be done to fix perf builds for non-x86
arches.
josh
next prev parent reply other threads:[~2012-11-12 20:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 12:51 [GIT PULL] UAPI: perf fixes David Howells
2012-11-12 20:23 ` Josh Boyer [this message]
2012-11-13 11:11 ` David Howells
2012-11-13 11:12 ` David Howells
2012-11-13 12:51 ` Josh Boyer
2012-11-13 15:24 ` David Howells
2012-11-13 15:42 ` Josh Boyer
2012-11-13 16:34 ` Arnaldo Carvalho de Melo
2012-11-15 2:23 ` Xiao Guangrong
2012-11-15 6:17 ` [PATCH 1/2] perf kvm: rename perf_kvm to perf_kvm_stat Xiao Guangrong
2012-11-15 6:17 ` [PATCH 2/2] perf kvm: fix building perf kvm on PowerPC Xiao Guangrong
2012-11-15 10:46 ` David Howells
2012-11-19 8:19 ` Xiao Guangrong
2012-12-01 11:21 ` [tip:perf/urgent] perf kvm: Fix building perf kvm on non x86 arches tip-bot for Xiao Guangrong
2012-11-19 22:22 ` [PATCH 2/2] perf kvm: fix building perf kvm on PowerPC David Howells
2012-12-01 11:20 ` [tip:perf/urgent] perf kvm: Rename perf_kvm to perf_kvm_stat tip-bot for Xiao Guangrong
2012-12-01 11:15 ` [tip:perf/urgent] tools: Define a Makefile function to do subdir processing tip-bot for David Howells
2012-12-01 11:16 ` [tip:perf/urgent] tools: Honour the O= flag when tool build called from a higher Makefile tip-bot for David Howells
2012-12-08 15:07 ` [tip:perf/core] tools: Define a Makefile function to do subdir processing tip-bot for David Howells
2012-12-08 15:08 ` [tip:perf/core] tools: Honour the O= flag when tool build called from a higher Makefile tip-bot for David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+5PVA5vMyNmQYCLX315Jc+kN9zQuZo_h0Devpjfr43TezE-qA@mail.gmail.com \
--to=jwboyer@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=bp@alien8.de \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).