From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759307AbbFBORi (ORCPT ); Tue, 2 Jun 2015 10:17:38 -0400 Received: from mail-qg0-f53.google.com ([209.85.192.53]:35316 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758633AbbFBOR2 (ORCPT ); Tue, 2 Jun 2015 10:17:28 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433207682-15064-1-git-send-email-labbott@fedoraproject.org> Date: Tue, 2 Jun 2015 10:17:27 -0400 X-Google-Sender-Auth: rSmNwopUw3n3laQwEmmErveQG3M Message-ID: Subject: Re: [PATCH 1/2] Bluetooth: Add reset_resume function From: Josh Boyer To: Marcel Holtmann Cc: Laura Abbott , Alan Stern , Takashi Iwai , Oliver Neukum , Ming Lei , "David S. Miller" , Johan Hedberg , "Rafael J. Wysocki" , "Gustavo F. Padovan" , BlueZ development , Linux Kernel Mailing List , USB list , netdev Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 1, 2015 at 9:28 PM, Marcel Holtmann wrote: > Hi Laura, > >> Bluetooth devices off of some buses such as USB may lose power across >> suspend/resume. When this happens, drivers may need to have the setup >> function called again and behave differently than a cold power on. >> Add a reset_resume function for drivers to call. During the >> reset_resume case, the flag HCI_RESET_RESUME will be set to allow >> drivers to differentate. >> >> Signed-off-by: Laura Abbott >> --- >> This matches with what hci_reset_dev does and also ensures >> the setup function gets called again. >> --- >> include/net/bluetooth/hci.h | 1 + >> include/net/bluetooth/hci_core.h | 1 + >> net/bluetooth/hci_core.c | 16 ++++++++++++++++ >> 3 files changed, 18 insertions(+) >> >> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h >> index d95da83..6285410 100644 >> --- a/include/net/bluetooth/hci.h >> +++ b/include/net/bluetooth/hci.h >> @@ -185,6 +185,7 @@ enum { >> HCI_RAW, >> >> HCI_RESET, >> + HCI_RESET_RESUME, >> }; > > no more addition to this list of flags please. These are userspace exposed flags and with that ABI that we are never ever touching again. If you need flags on a per device basis, then use the second list. It would be helpful for other developers if you added a comment to that effect above the enum definition. Otherwise you're going to wind up repeating yourself over time. Also, if they're exposed to userspace, should this file be using the uapi mechanism? I'm confused how they're exposed today, given that they aren't installed via 'make headers_install'. Is this manually synced with some other .h file in a userspace package? josh