From: Josh Boyer <jwboyer@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Edac Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] edac/ppc4xx_edac: Fix compilation
Date: Wed, 1 Feb 2012 12:41:10 -0500 [thread overview]
Message-ID: <CA+5PVA6oGQOouEPxUds8jWM9hccJDikC2veoo1nf6HbWgnVzbQ@mail.gmail.com> (raw)
In-Reply-To: <1328053058-30752-1-git-send-email-mchehab@redhat.com>
On Tue, Jan 31, 2012 at 6:37 PM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> It seems that nobody is cross-compiling for this arch anymore...
>
> drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_probe':
> drivers/edac/ppc4xx_edac.c:188:12: error: storage class specified for parameter 'ppc4xx_edac_remove'
> ...
> drivers/edac/ppc4xx_edac.c:1068:19: error: 'match' undeclared (first use in this function)
> drivers/edac/ppc4xx_edac.c:1068:19: note: each undeclared identifier is reported only once for each function it appears in
> drivers/edac/ppc4xx_edac.c:1068:36: warning: left-hand operand of comma expression has no effect [-Wunused-value]
Ugh. The linux-next tree builds ppc44x_defconfig daily, but I don't
have this module enabled there. I'll get it added.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Acked-by: Josh Boyer <jwboyer@gmail.com>
> ---
> drivers/edac/ppc4xx_edac.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
> index 0f06f14..1adaddf 100644
> --- a/drivers/edac/ppc4xx_edac.c
> +++ b/drivers/edac/ppc4xx_edac.c
> @@ -184,7 +184,7 @@ struct ppc4xx_ecc_status {
>
> /* Function Prototypes */
>
> -static int ppc4xx_edac_probe(struct platform_device *device)
> +static int ppc4xx_edac_probe(struct platform_device *device);
> static int ppc4xx_edac_remove(struct platform_device *device);
>
> /* Global Variables */
> @@ -1065,7 +1065,7 @@ ppc4xx_edac_mc_init(struct mem_ctl_info *mci,
>
> mci->mod_name = PPC4XX_EDAC_MODULE_NAME;
> mci->mod_ver = PPC4XX_EDAC_MODULE_REVISION;
> - mci->ctl_name = match->compatible,
> + mci->ctl_name = ppc4xx_edac_match->compatible,
> mci->dev_name = np->full_name;
>
> /* Initialize callbacks */
> --
> 1.7.8
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2012-02-01 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 23:37 [PATCH 1/2] edac/ppc4xx_edac: Fix compilation Mauro Carvalho Chehab
2012-01-31 23:37 ` [PATCH RFC 2/2] edac-mc: Allow reporting errors on a non-csrow oriented way Mauro Carvalho Chehab
2012-02-01 17:41 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+5PVA6oGQOouEPxUds8jWM9hccJDikC2veoo1nf6HbWgnVzbQ@mail.gmail.com \
--to=jwboyer@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).