From: Josh Boyer <jwboyer@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Thomas Meyer <thomas@m3y3r.de>,
David Miller <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"jcliburn@gmail.com" <jcliburn@gmail.com>,
"chris.snook@gmail.com" <chris.snook@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] atl1c: dont use highprio tx queue
Date: Thu, 16 Feb 2012 07:36:09 -0500 [thread overview]
Message-ID: <CA+5PVA74bejZhPxUAFHaeHLB0NBd7PCRc1sQvmSY7QdmarCWEw@mail.gmail.com> (raw)
In-Reply-To: <1329374591.5646.23.camel@edumazet-laptop>
On Thu, Feb 16, 2012 at 1:43 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> This driver attempts to use two TX rings but lacks proper support :
>
> 1) IRQ handler only takes care of TX completion on first TX ring
> 2) the stop/start logic uses the legacy functions (for non multiqueue
> drivers)
>
> This means all packets witk skb mark set to 1 are sent through high
> queue but are never cleaned and queue eventualy fills and block the
> device, triggering the infamous "NETDEV WATCHDOG" message.
>
> Lets use a single TX ring to fix the problem, this driver is not a real
> multiqueue one yet.
>
> Minimal fix for stable kernels.
>
> Reported-by: Thomas Meyer <thomas@m3y3r.de>
> Tested-by: Thomas Meyer <thomas@m3y3r.de>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Jay Cliburn <jcliburn@gmail.com>
> Cc: Chris Snook <chris.snook@gmail.com>
As I think David handles netdev patches a bit differently for stable releases,
I'd like to suggest this get included in the next batch for the 3.2 kernel.
We've been seeing the bug this patch fixes in Fedora for quite a while now.
josh
next prev parent reply other threads:[~2012-02-16 12:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 16:16 NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out Thomas Meyer
2012-02-13 21:00 ` Josh Boyer
2012-02-14 7:36 ` Eric Dumazet
2012-02-16 4:34 ` Eric Dumazet
2012-02-16 6:13 ` Thomas Meyer
2012-02-16 6:18 ` Eric Dumazet
2012-02-16 6:23 ` Thomas Meyer
2012-02-16 6:43 ` [PATCH] atl1c: dont use highprio tx queue Eric Dumazet
2012-02-16 12:36 ` Josh Boyer [this message]
2012-02-16 13:12 ` Eric Dumazet
2012-02-19 23:59 ` David Miller
2012-02-16 7:09 ` NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out Huang, Xiong
2012-02-21 17:56 ` Thomas Meyer
2012-02-21 18:14 ` Eric Dumazet
2012-02-24 19:20 ` Eric Dumazet
2012-02-25 9:52 ` Thomas Meyer
2012-06-06 0:38 ` Jonathan Nieder
2012-06-07 12:37 ` Thomas Meyer
2012-06-07 12:52 ` Eric Dumazet
2012-06-07 21:30 ` Huang, Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+5PVA74bejZhPxUAFHaeHLB0NBd7PCRc1sQvmSY7QdmarCWEw@mail.gmail.com \
--to=jwboyer@gmail.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jcliburn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).