From: Josh Boyer <jwboyer@fedoraproject.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Vincent Donnefort <vdonnefort@gmail.com>,
Bryan Wu <cooloney@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Tejun Heo <tj@kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "leds: convert blink timer to workqueue"
Date: Tue, 2 Sep 2014 11:55:31 -0400 [thread overview]
Message-ID: <CA+5PVA7oZVWAiVTyiRkW5H1jB7JTPLZv==upSm6FcPZyj8hV5A@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1409021101450.2481@pobox.suse.cz>
On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758.
>
> It's broken as it changes led_blink_set() in a way that it can now sleep
> (while synchronously waiting for workqueue to be cancelled). That's a
> problem, because it's possible that this function gets called from atomic
> context (tpt_trig_timer() takes a readlock and thus disables preemption).
>
> This has been brought up 3 weeks ago already [1] but no proper fix has
> materialized, and I keep seeing the problem since 3.18-rc1.
>
> [1] https://lkml.org/lkml/2014/8/16/128
FWIW we're seeing it reported in Fedora too. Perhaps a revert is the
right approach for now.
josh
next prev parent reply other threads:[~2014-09-02 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 9:03 [PATCH] Revert "leds: convert blink timer to workqueue" Jiri Kosina
2014-09-02 15:55 ` Josh Boyer [this message]
2014-09-02 16:49 ` Bryan Wu
2014-09-02 17:02 ` Bryan Wu
2014-09-02 17:13 ` Josh Boyer
2014-09-02 21:22 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+5PVA7oZVWAiVTyiRkW5H1jB7JTPLZv==upSm6FcPZyj8hV5A@mail.gmail.com' \
--to=jwboyer@fedoraproject.org \
--cc=cooloney@gmail.com \
--cc=hughd@google.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).