From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754949Ab3LQQEu (ORCPT ); Tue, 17 Dec 2013 11:04:50 -0500 Received: from mail-ob0-f176.google.com ([209.85.214.176]:54845 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335Ab3LQQEr (ORCPT ); Tue, 17 Dec 2013 11:04:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <201201281445.49377.rjw@sisk.pl> <201202172159.15396.rjw@sisk.pl> <201205252113.50900.rjw@sisk.pl> Date: Tue, 17 Dec 2013 11:04:46 -0500 X-Google-Sender-Auth: EOD8rnLOA-BbLa68vjxQOlnKuTs Message-ID: Subject: Re: [RFC][PATCH] PM / Sleep: Freeze filesystems during system suspend/hibernation From: Josh Boyer To: "Rafael J. Wysocki" Cc: Linux PM list , LKML , Jan Kara , linux-fsdevel@vger.kernel.org, Dave Chinner , Nigel Cunningham , Pavel Machek , "Srivatsa S. Bhat" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 17, 2013 at 11:03 AM, Josh Boyer wrote: > On Fri, May 25, 2012 at 3:13 PM, Rafael J. Wysocki wrote: >> On Friday, May 25, 2012, Josh Boyer wrote: >>> On Fri, Feb 17, 2012 at 3:59 PM, Rafael J. Wysocki wrote: >>> >> commit b94887bbc0621e1e8402e7f0ec4bc3adf46c9a6e >>> >> Author: Rafael J. Wysocki >>> >> Date: Fri Feb 17 12:42:08 2012 -0500 >>> >> >>> >> Freeze all filesystems during system suspend and (kernel-driven) >>> >> hibernation by calling freeze_supers() for all superblocks and thaw >>> >> them during the subsequent resume with the help of thaw_supers(). >>> >> >>> >> This makes filesystems stay in a consistent state in case something >>> >> goes wrong between system suspend (or hibernation) and the subsequent >>> >> resume (e.g. journal replays won't be necessary in those cases). In >>> >> particular, this should help to solve a long-standing issue that, in >>> >> some cases, during resume from hibernation the boot loader causes the >>> >> journal to be replied for the filesystem containing the kernel image >>> >> and/or initrd causing it to become inconsistent with the information >>> >> stored in the hibernation image. >>> >> >>> >> The user-space-driven hibernation (s2disk) is not covered by this >>> >> change, because the freezing of filesystems prevents s2disk from >>> >> accessing device special files it needs to do its job. >>> >> >>> >> This change is based on earlier work by Nigel Cunningham. >>> >> >>> >> Signed-off-by: Rafael J. Wysocki >>> >> >>> >> Rebased to 3.3-rc3 by Josh Boyer >>> >>> Did this patch ever wind up going anywhere? Fedora has it sitting in >>> our tree with a comment that says "rebase" and I don't see it in the >>> linux-next tree at all. >>> >>> Did if fall through the cracks or was it NAKed somewhere? >> >> No, it wasn't in principle. There were some comments I haven't addressed yet. > > Dredging up a really old thread, sorry. > > We're still carrying this patch along in Fedora. Should we drop it at > this point, or is it still eventually going to head upstream? Fixed Rafael's email address. (Double sorry.) josh