From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67FCEC2B9F8 for ; Tue, 25 May 2021 05:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D25461414 for ; Tue, 25 May 2021 05:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230428AbhEYFKM (ORCPT ); Tue, 25 May 2021 01:10:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230149AbhEYFKK (ORCPT ); Tue, 25 May 2021 01:10:10 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00CBBC061574 for ; Mon, 24 May 2021 22:08:39 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id b9so10019443ejc.13 for ; Mon, 24 May 2021 22:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gugbK3GuzJfswuusq4RJrhrh84MP7SfEG2HwlvTjBS8=; b=HfQBKA0PZvggbiJvcfoUX5ZHlxZkF8uTSfI7G8eLzMk6zrI/wztVjwMjWZihGYzBRN lCvUYCYAQ/kqxrjAhst8WVNcnQCCYkuhhmgn9XnTIfY7XcL+qVU4S33guotrj8w81y1v Dq1kuHAbY8TWlhieaY4cuqg+b3Gyiql1WCyJhB4KEKI/S/6QXcs18YsGG8xxZPYRizbK gXiO16e/QsgYYiyJg5A39pRP7NWUb8AKfr56L97ZMedFTZJ1suXLQd5tWORaSz3V8XMw +b6HiaaXA3+SqosL6NsH+shedR5bygx92iBijecjxd7Euf2v7ZrGZ4YbNuKYPh/gvv1Q 9ywA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gugbK3GuzJfswuusq4RJrhrh84MP7SfEG2HwlvTjBS8=; b=jMgg8biduCtT3MSZ5nU0Ai+pjB52NxKefMckQWH6q/8ZpscCmw1vEZqaMZcsp1n7Ds kxQTNa0E6wSqObcqHGh2tR+cw4OfQ2sKZzea/hiLXxpXFKkZqVeB+MnKNaUQRup+gnqg YWefGcCxtxcQshhMtSQirebM8CiPT9jbj67CqOvFmbFlxkjjyubKftlclkVeODgzvAs1 VGnsax8rEfPFnkA/VzqtGtbfVot6Oq70SjN4R5HvDrztw+XdPyMupSZ+GmJWlfxUiPTF CIDwpKmpLHCuaS3l6TzGy1VS7mNZDVQeqGeQwRwAJRr5SnVt68vXzRMW6OyAEre6lJtM HZyg== X-Gm-Message-State: AOAM531JoIJilpVsn45DoZyLlMbS9Fu+0x5U4yeXdtjDpAhdcdCrIqnO 8vPxQnWPsCK/9Ll/gux2E6da5PrYHG3WdaeekbQ= X-Google-Smtp-Source: ABdhPJz8jf3g2jOCUYmW4eaZBAACOPG2cjRnMDsfwyaOp8HKwo+Bh1+GaD5muGVBxlpj6Sbrb1/a0oWbZpOh7MjftAo= X-Received: by 2002:a17:906:1d0a:: with SMTP id n10mr26609823ejh.341.1621919318592; Mon, 24 May 2021 22:08:38 -0700 (PDT) MIME-Version: 1.0 References: <20210523001806.3927609-1-tpiepho@gmail.com> In-Reply-To: From: Trent Piepho Date: Mon, 24 May 2021 22:08:27 -0700 Message-ID: Subject: Re: [PATCH] lib/math/rational.c: Fix divide by zero To: Randy Dunlap Cc: David Gow , Daniel Latypov , Brendan Higgins , Andy Shevchenko , Linux Kernel Mailing List , andy@kernel.org, Andrew Morton , Oskar Schirmer , Yiyuan Guo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 6:49 PM Randy Dunlap wrote: > > > Personally, I think that RATIONAL is probably an okay thing to select > > here: it's not as heavyweight as drivers/filesystems/etc, and our > > general guidance here is "avoid select where sensible to do so", not > > "don't use it under any circumstances". > > RATIONAL does not have a prompt string, so depending on it would not > be reliable. I.e., it is meant to be selected. Yes, there are no out of tree or userspace users of it. The only possible way to use it, is if some code in the kernel uses it. So that code can select it. If it could be used by out of tree modules, then there should be an entry for it, like some of the compression and crc routines got so they could be turned on for out of tree modules when nothing in the kernel config used them.