* [PATCH] kernel/watchdog: add missing prototypes for weak functions
@ 2018-06-06 19:42 Mathieu Malaterre
2018-11-06 20:35 ` Mathieu Malaterre
2018-11-06 22:21 ` [tip:core/urgent] watchdog/core: Add " tip-bot for Mathieu Malaterre
0 siblings, 2 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2018-06-06 19:42 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Mathieu Malaterre, Babu Moger, linux-kernel
In commit 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to
separate file") two new functions were added ‘watchdog_nmi_enable’ and
‘watchdog_nmi_disable’ the functions were changed from static to weak.
In which case expose the function declarations in header file.
Silence the following gcc warnings:
kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes]
kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes]
Cc: Babu Moger <babu.moger@oracle.com>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
include/linux/nmi.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/nmi.h b/include/linux/nmi.h
index b8d868d23e79..50d143995338 100644
--- a/include/linux/nmi.h
+++ b/include/linux/nmi.h
@@ -113,6 +113,8 @@ static inline int hardlockup_detector_perf_init(void) { return 0; }
void watchdog_nmi_stop(void);
void watchdog_nmi_start(void);
int watchdog_nmi_probe(void);
+int watchdog_nmi_enable(unsigned int cpu);
+void watchdog_nmi_disable(unsigned int cpu);
/**
* touch_nmi_watchdog - restart NMI watchdog timeout.
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel/watchdog: add missing prototypes for weak functions
2018-06-06 19:42 [PATCH] kernel/watchdog: add missing prototypes for weak functions Mathieu Malaterre
@ 2018-11-06 20:35 ` Mathieu Malaterre
2018-11-06 22:21 ` [tip:core/urgent] watchdog/core: Add " tip-bot for Mathieu Malaterre
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2018-11-06 20:35 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: LKML, Babu Moger
ping ?
On Wed, Jun 6, 2018 at 9:42 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> In commit 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to
> separate file") two new functions were added ‘watchdog_nmi_enable’ and
> ‘watchdog_nmi_disable’ the functions were changed from static to weak.
> In which case expose the function declarations in header file.
>
> Silence the following gcc warnings:
>
> kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes]
> kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes]
>
> Cc: Babu Moger <babu.moger@oracle.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> include/linux/nmi.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/nmi.h b/include/linux/nmi.h
> index b8d868d23e79..50d143995338 100644
> --- a/include/linux/nmi.h
> +++ b/include/linux/nmi.h
> @@ -113,6 +113,8 @@ static inline int hardlockup_detector_perf_init(void) { return 0; }
> void watchdog_nmi_stop(void);
> void watchdog_nmi_start(void);
> int watchdog_nmi_probe(void);
> +int watchdog_nmi_enable(unsigned int cpu);
> +void watchdog_nmi_disable(unsigned int cpu);
>
> /**
> * touch_nmi_watchdog - restart NMI watchdog timeout.
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:core/urgent] watchdog/core: Add missing prototypes for weak functions
2018-06-06 19:42 [PATCH] kernel/watchdog: add missing prototypes for weak functions Mathieu Malaterre
2018-11-06 20:35 ` Mathieu Malaterre
@ 2018-11-06 22:21 ` tip-bot for Mathieu Malaterre
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Mathieu Malaterre @ 2018-11-06 22:21 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, linux-kernel, malat, babu.moger, mingo, hpa
Commit-ID: 81bd415c91eb966118d773dddf254aebf3022411
Gitweb: https://git.kernel.org/tip/81bd415c91eb966118d773dddf254aebf3022411
Author: Mathieu Malaterre <malat@debian.org>
AuthorDate: Wed, 6 Jun 2018 21:42:32 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 6 Nov 2018 21:58:00 +0100
watchdog/core: Add missing prototypes for weak functions
The split out of the hard lockup detector exposed two new weak functions,
but no prototypes for them, which triggers the build warning:
kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes]
kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes]
Add the prototypes.
Fixes: 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to separate file")
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Babu Moger <babu.moger@oracle.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20180606194232.17653-1-malat@debian.org
---
include/linux/nmi.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/nmi.h b/include/linux/nmi.h
index 08f9247e9827..9003e29cde46 100644
--- a/include/linux/nmi.h
+++ b/include/linux/nmi.h
@@ -119,6 +119,8 @@ static inline int hardlockup_detector_perf_init(void) { return 0; }
void watchdog_nmi_stop(void);
void watchdog_nmi_start(void);
int watchdog_nmi_probe(void);
+int watchdog_nmi_enable(unsigned int cpu);
+void watchdog_nmi_disable(unsigned int cpu);
/**
* touch_nmi_watchdog - restart NMI watchdog timeout.
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-06 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-06 19:42 [PATCH] kernel/watchdog: add missing prototypes for weak functions Mathieu Malaterre
2018-11-06 20:35 ` Mathieu Malaterre
2018-11-06 22:21 ` [tip:core/urgent] watchdog/core: Add " tip-bot for Mathieu Malaterre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).