From: Mathieu Malaterre <malat@debian.org>
To: Christophe LEROY <christophe.leroy@c-s.fr>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic
Date: Wed, 5 Dec 2018 08:40:31 +0100 [thread overview]
Message-ID: <CA+7wUswgOLp8z6-VOf86=dSf1PCOT4CW4RpMOC-J_p2xBiZkwA@mail.gmail.com> (raw)
In-Reply-To: <ba978bc1-e137-8abf-01a0-e1c68341a95f@c-s.fr>
On Tue, Dec 4, 2018 at 10:28 PM Christophe LEROY
<christophe.leroy@c-s.fr> wrote:
>
>
>
> Le 04/12/2018 à 21:53, Mathieu Malaterre a écrit :
> > The code:
> >
> > ifdef CONFIG_6xx
> > KBUILD_CFLAGS += -mcpu=powerpc
> > endif
> >
> > was added in 2006 in commit f48b8296b315 ("[PATCH] powerpc32: Set cpu
> > explicitly in kernel compiles"). This change was acceptable since the
> > TARGET_CPU logic was 64-bit only.
> >
> > Since commit 0e00a8c9fd92 ("powerpc: Allow CPU selection
> > also on PPC32") this logic is no longer acceptable after the TARGET_CPU
> > specific. It currently appends -mcpu=powerpc at the end of the command
> > line, after any TARGET_CPU specific:
> >
> > gcc -Wp,-MD,init/.do_mounts.o.d ...
> > -mcpu=powerpc -mbig-endian -m32 ...
> > -mcpu=e300c2 ...
> > -mcpu=powerpc ...
> > ../init/do_mounts.c
> >
> > Cc: Christophe Leroy <christophe.leroy@c-s.fr>
> > Fixes: 0e00a8c9fd92 ("powerpc: Allow CPU selection also on PPC32")
> > Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> > Link: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg142315.html
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
> > ---
> > arch/powerpc/Makefile | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> > index 8a2ce14d68d0..544b30667ea5 100644
> > --- a/arch/powerpc/Makefile
> > +++ b/arch/powerpc/Makefile
> > @@ -30,6 +30,10 @@ endif
> > endif
> > endif
> >
> > +ifdef CONFIG_6xx
> > +KBUILD_CFLAGS += -mcpu=powerpc
> > +endif
> > +
>
> Could you make the patch on top of my serie (ie after the change of
> CONFIG_6xx to CONFIG_BOOK3S_32 ?
Sure. That will defeat the point of the Fixes: line, but I guess who
cares anyway ? Will re-submit asap.
> The serie is in origin/next-test
>
> Thanks,
> Christophe
>
> > ifeq ($(CROSS_COMPILE),)
> > KBUILD_DEFCONFIG := $(shell uname -m)_defconfig
> > else
> > @@ -241,10 +245,6 @@ KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm)
> > # often slow when they are implemented at all
> > KBUILD_CFLAGS += $(call cc-option,-mno-string)
> >
> > -ifdef CONFIG_6xx
> > -KBUILD_CFLAGS += -mcpu=powerpc
> > -endif
> > -
> > cpu-as-$(CONFIG_4xx) += -Wa,-m405
> > cpu-as-$(CONFIG_ALTIVEC) += $(call as-option,-Wa$(comma)-maltivec)
> > cpu-as-$(CONFIG_E200) += -Wa,-me200
> >
next prev parent reply other threads:[~2018-12-05 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 20:53 [PATCH] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic Mathieu Malaterre
2018-12-04 21:28 ` Christophe LEROY
2018-12-05 7:40 ` Mathieu Malaterre [this message]
2018-12-05 17:53 ` [PATCH v2] " Mathieu Malaterre
2018-12-22 9:54 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+7wUswgOLp8z6-VOf86=dSf1PCOT4CW4RpMOC-J_p2xBiZkwA@mail.gmail.com' \
--to=malat@debian.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).