Re: [PATCH v2 01/19] powerpc/powermac: Mark variable x as unused

[Mathieu Malaterre <malat@debian.org>]

On Thu, Mar 29, 2018 at 6:07 PM, LEROY Christophe
<christophe.leroy@c-s.fr> wrote:
> Mathieu Malaterre <malat@debian.org> a écrit :
>
>
>> Since the value of x is never intended to be read, declare it with gcc
>> attribute as unused. Fix warning treated as error with W=1:
>>
>>   arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable ‘x’
>> set but not used [-Werror=unused-but-set-variable]
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>> v2: move x variable within its local scope
>>
>>  arch/powerpc/platforms/powermac/bootx_init.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/powermac/bootx_init.c
>> b/arch/powerpc/platforms/powermac/bootx_init.c
>> index c3c9bbb3573a..d44e8571c1ec 100644
>> --- a/arch/powerpc/platforms/powermac/bootx_init.c
>> +++ b/arch/powerpc/platforms/powermac/bootx_init.c
>> @@ -468,7 +468,7 @@ void __init bootx_init(unsigned long r3, unsigned long
>> r4)
>>         boot_infos_t *bi = (boot_infos_t *) r4;
>>         unsigned long hdr;
>>         unsigned long space;
>> -       unsigned long ptr, x;
>> +       unsigned long ptr;
>>         char *model;
>>         unsigned long offset = reloc_offset();
>>
>> @@ -562,6 +562,7 @@ void __init bootx_init(unsigned long r3, unsigned long
>> r4)
>>          * MMU switched OFF, so this should not be useful anymore.
>>          */
>>         if (bi->version < 4) {
>> +               unsigned long x __maybe_unused;
>>                 bootx_printf("Touching pages...\n");
>
>
> Stylewise, there should be an empty line after your declaration.

See v3

> But I believe you should remove that ugly loop and replace it by a call to
> fault_in_pages_readable()

I have no idea on how to test the the new code, and it did not look
straightforward.

> Christophe
>>
>>
>>                 /*
>> --
>> 2.11.0
>
>
>