From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbbDCDjc (ORCPT ); Thu, 2 Apr 2015 23:39:32 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:35982 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbbDCDj2 (ORCPT ); Thu, 2 Apr 2015 23:39:28 -0400 MIME-Version: 1.0 In-Reply-To: <550C03D3.7090504@ti.com> References: <1425452771-19313-1-git-send-email-Ying.Liu@freescale.com> <54FEDD5D.4000104@ti.com> <20150311030327.GA3724@victor> <550C03D3.7090504@ti.com> Date: Fri, 3 Apr 2015 11:39:27 +0800 Message-ID: Subject: Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers From: Liu Ying To: Tomi Valkeinen Cc: Liu Ying , linux-fbdev@vger.kernel.org, Peter Chen , Jean-Christophe Plagniol-Villard , Fabio Estevam , Greg Kroah-Hartman , linux-kernel , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-03-20 19:26 GMT+08:00 Tomi Valkeinen : > On 11/03/15 05:03, Liu Ying wrote: > >>> Why do you check for host->enabled here, but not elsewhere? >> >> We need this check here to make sure the axi clock reference count is no greater >> than 1. Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() and > > Why is that? The clock framework handles ref counting for you. All the > driver needs to take care of is to call as many times disable as it > calls enable. Okay. I'll remove the check and send another version. Regards, Liu Ying > > Tomi > >